From 04355d6626cc07891bd4c30609e7957183119aaf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Lozier?= Date: Wed, 26 Oct 2016 10:04:00 -0400 Subject: [PATCH] Fix #268 --- .../IronPython/IronPython.Modules/_codecs.cs | 8 ++++---- .../Tests/modules/io_related/codecs_test.py | 17 ++++------------- 2 files changed, 8 insertions(+), 17 deletions(-) diff --git a/Languages/IronPython/IronPython.Modules/_codecs.cs b/Languages/IronPython/IronPython.Modules/_codecs.cs index 6a6c1483f9..aae04559db 100644 --- a/Languages/IronPython/IronPython.Modules/_codecs.cs +++ b/Languages/IronPython/IronPython.Modules/_codecs.cs @@ -116,7 +116,7 @@ public class EncodingMap { return PythonTuple.MakeTuple(res.ToString(), res.Length); } - public static object charbuffer_encode() { + public static object charbuffer_encode(string input) { throw PythonOps.NotImplementedError("charbuffer_encode"); } @@ -366,7 +366,7 @@ public class EncodingMap { ); } - public static object readbuffer_encode() { + public static object readbuffer_encode(string input) { throw PythonOps.NotImplementedError("readbuffer_encode"); } @@ -380,11 +380,11 @@ public class EncodingMap { #region Unicode Escape Encoding - public static PythonTuple unicode_escape_decode() { + public static PythonTuple unicode_escape_decode(string input) { throw PythonOps.NotImplementedError("unicode_escape_decode"); } - public static PythonTuple unicode_escape_encode() { + public static PythonTuple unicode_escape_encode(string input) { throw PythonOps.NotImplementedError("unicode_escape_encode"); } diff --git a/Languages/IronPython/Tests/modules/io_related/codecs_test.py b/Languages/IronPython/Tests/modules/io_related/codecs_test.py index bdfa67613d..87476365fd 100644 --- a/Languages/IronPython/Tests/modules/io_related/codecs_test.py +++ b/Languages/IronPython/Tests/modules/io_related/codecs_test.py @@ -378,11 +378,8 @@ def test_utf_8_encode(): def test_charbuffer_encode(): ''' ''' - #function takes one parameter, not 0 if is_cli: - #http://ironpython.codeplex.com/WorkItem/View.aspx?WorkItemId=4563 - #AssertError(NotImplementedError, codecs.charbuffer_encode, "abc") - AssertError(NotImplementedError, codecs.charbuffer_encode) + AssertError(NotImplementedError, codecs.charbuffer_encode, "abc") def test_charmap_encode(): #Sanity @@ -438,26 +435,20 @@ def test_mbcs_encode(): def test_readbuffer_encode(): ''' ''' - #http://ironpython.codeplex.com/WorkItem/View.aspx?WorkItemId=4563 if is_cli: - #AssertError(NotImplementedError, codecs.readbuffer_encode, "abc") - AssertError(NotImplementedError, codecs.readbuffer_encode) + AssertError(NotImplementedError, codecs.readbuffer_encode, "abc") def test_unicode_escape_decode(): ''' ''' - #http://ironpython.codeplex.com/WorkItem/View.aspx?WorkItemId=4563 if is_cli: - #AssertError(NotImplementedError, codecs.unicode_escape_decode, "abc") - AssertError(NotImplementedError, codecs.unicode_escape_decode) + AssertError(NotImplementedError, codecs.unicode_escape_decode, "abc") def test_unicode_escape_encode(): ''' ''' - #http://ironpython.codeplex.com/WorkItem/View.aspx?WorkItemId=4563 if is_cli: - #AssertError(NotImplementedError, codecs.unicode_escape_encode, "abc") - AssertError(NotImplementedError, codecs.unicode_escape_encode) + AssertError(NotImplementedError, codecs.unicode_escape_encode, "abc") def test_utf_16_encode(): #Sanity