Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Time#strftime - any text not listed as a directive in the given format st #28

Closed
wants to merge 2 commits into from

2 participants

@enricosada

Time#strftime - any text not listed as a directive in the given format string will be passed through to the output string

now a mspec test on core/time/strftime_spec.rb is green so i removed the 'fails:' from ironruby-tags-19

the guard for ruby compatibility >= 1.9 is needed?

@enricosada

the check for ruby compatibility is not needed (as said in ml), i will remove it. dont pull now.

@enricosada

now should work, i removed the 1.9 check and the useless > 1.8.6 check

@tmat
Owner

Merged.

@tmat tmat closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 2, 2011
  1. @enricosada

    Time#strftime - any text not listed as a directive in the given forma…

    enricosada authored
    …t string will be passed through to the output string
Commits on Aug 3, 2011
  1. @enricosada
This page is out of date. Refresh to see the latest.
View
8 Languages/Ruby/Libraries/Builtins/RubyTime.cs
@@ -998,11 +998,9 @@ public static class RubyTimeOps {
break;
default:
- if (context.RubyOptions.Compatibility > RubyCompatibility.Ruby186) {
- result.Append(character);
- break;
- }
- return MutableString.CreateEmpty();
+ result.Append('%');
+ result.Append(character);
+ break;
}
if (dateTimeFormat != null) {
View
1  Languages/Ruby/Tests/mspec/ironruby-tags-19/core/time/strftime_tags.txt
@@ -1,2 +1 @@
-fails:Time#strftime ignores invalid or incomplete directives
fails:Time#strftime supports GNU modificators
Something went wrong with that request. Please try again.