Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
issue #32408 #65
I have fixed 32408 and did testing with test_ast.py
The submitted test_ast.py is modified. I have added some tests to help me with the issues.
I also believe that version of Python standard library which comes with HEAD is older than what came with 18.104.22.168. This causes test_increment_lineno to fail.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Awesome work. I might not get a chance to review it until the weekend but it looks good. Just wanted to let you know it isn't being ignored.
Yes, the stdlib on master is behind ipy-27-maint. Eventually master will have the 3.2 stdlib but I haven't got around to it yet because it will be a huge change.
I tried to pull it in but unfortunately it doesn't compile for WP7 or Android - their compilers don't understand the [Optional] declarations. You'll need to supply a constructor that does not have the [Optional] parameters.
There's also a couple of places where you used
Would it change the semantic from optional - "any combination allowed" to optional - "all or nothing"?
I have copied the [Optional] use pattern from StringOps.cs
Looking at it again, you do want to [Optional]s there, for IronPython. The problem is that the C# 4 compiler recognizes [Optional] and there are calls within the module that depend on that.
For example, you call
I guess there are two options - always pass all of the parameters in the C# code, or add extra constructors for the older compilers without the [Optional] parameters and make them internal so that IronPython won't see them.
You'd then have
which should preserve the [Optional] semantics for IronPython and make the older compilers happy.