7.x-1.3 cherry-picking #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fallback for missing genre tags
fixed ds_comp
Cleaned up markup.
made subjects repeatable
fixed form
Form changes
README normalization
Change the default value to be consistent.
new package and admin submenu
|
I should grab #92 as well once it is merged. |
Update outdated Travis configurations.
…cherrypick Conflicts: islandora_scholar.info
|
@nigelgbanks let me know if this reflects what you mentioned on the list. A little ugly, but I think it does the job. |
| 'type' => MENU_NORMAL_ITEM, | ||
| 'page callback' => 'drupal_get_form', | ||
| 'page arguments' => array('islandora_scholar_admin_form'), | ||
| 'access arguments' => array('access administration pages'), | ||
| 'file' => 'includes/admin.form.inc', | ||
| ), | ||
| 'admin/islandora/scholar/base' => array( | ||
| 'admin/islandora/solution_pack_config/scholar/base' => array( |
There was a problem hiding this comment.
Can't merge this, it will break as the Islandora Menu changes are not part of this release.
"admin/islandora/solution_pack_config"
|
There is a number of breaking changes in this pull request, as it uses menus not defined in the core Islandora module. The fixes that are included are fairly minor, I'd recommend not including this in the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grabbing the following commits for 7.x-1.3:
#93
#94
#97
#98
#99
#100