Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 5.3.3 to fail #216

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
3 participants
@whikloj
Copy link
Member

commented Apr 30, 2019

JIRA Ticket: https://jira.duraspace.org/browse/ISLANDORA-2424

What does this Pull Request do?

Allows PHP 5.3.3. to fail in Travis without marking the build as a failure.

How should this be tested?

Travis with test

Additional Notes:

  • Does this change the interface, add a new feature, or otherwise change behaviours that would require updating documentation? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

Interested parties

@Islandora/7-x-1-x-committers

@mjordan

mjordan approved these changes May 2, 2019

Copy link
Contributor

left a comment

This appears to be the preferred solution to allowing PHP 5.3.3 to fail.

@bondjimbond bondjimbond merged commit 494eeec into Islandora:7.x May 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.