Permalink
Commits on Aug 15, 2018
  1. Merge pull request #258 from bondjimbond/ISLANDORA-897

    DonRichards committed Aug 15, 2018
    ISLANDORA-897: Add scrolling to More Advanced Controls
Commits on Jul 26, 2018
  1. ISLANDORA-1402: Forbid URL-breaking characters in form names as a tem…

    d-r-p authored and DiegoPino committed Jul 26, 2018
    …porary solution (#257)
    
    * ISLANDORA-1402: Forbid URL-breaking characters in form names as a temporary solution.
    
    Forbid '/', '#' and '?' in form names for newly created forms.
    
    * ISLANDORA-1402 (continued)
    
    Also forbid '/', '#' and '?' in form names for copied forms.
    
    * ISLANDORA-1402: Encode form names in URLs instead of banning characters
    
    - revert the validation against '/', '#' and '?' in form names
    - rawurlencode form names in URLs (and rawurldecode them for usage)
    
    Note: This might break logic for code that is recycling the page
    callbacks of xml_form_builder.
    
    While at it, add breadcrumbs to the associations form, too.
Commits on Jun 15, 2018
  1. Add scrolling to More advanced

    Brandon Weigel
    Brandon Weigel committed Jun 15, 2018
Commits on Jun 14, 2018
  1. Merge pull request #254 from d-r-p/7.x-ISLANDORA-877

    rosiel committed Jun 14, 2018
    ISLANDORA-877: Prevent visible empty `div` for `datepicker` element
Commits on Jun 13, 2018
  1. ISLANDORA-2205: Re-design `creative_commons` element (#253)

    d-r-p authored and DiegoPino committed Jun 13, 2018
    * ISLANDORA-2205: Re-design `creative_commons` element
    
    Also, implement ISLANDORA-2208 and solve issues in
    Islandora/islandora_xml_forms#251
    
    Overview:
    - Honor '#default_value'
    - Allow CC0 & Public Domain Mark licenses
    - Graceful non-JS degradation
    - Allow overriding license version
    - Allow setting license URI manually
    - Validate versions, resp. license URIs
    - Cache last query to API for speed-up
    - Fix `<html>` wrapper of API response
    - Renounce to value callback; populate values
      in element creation function
    - Remove '#tree' logic in favor of manipulating
      `$form_state` directly
    
    * Code sanitation and minor changes
    
    - Move API response storage code in separate functions
      to avoid code duplication
    - Remove unnecessary '#weight' field in button element
    - Move comment inside clause
    - Update variables before delivering value, based on
      computed URI
    - Avoid "Illegal choice in License Jurisdiction element."
      error due to empty  (set to 'international'
      by default)
    
    * Minor change
    
    If version was set to blank to retrieve newest license,
    do not update that variable when not in manual mode.
    
    * Improve error handling, deconvolute logic, fix bugs
    
    - Catch site setup errors (and issue warning for admin)
    - Reduce level of nesting
    - Add comments for explanation
    - Rename and re-order utility functions
    - Improve legacy code and deprecate legacy functions
    - Fix minor bugs
    
    * "No license" selection on empty '#default_value'
    
    * Tiny caching improvement
    
    Avoid unnecessary second API query.
    
    * Prevent form submission during AJAX requests.
    
    * Address (most) comments by @DiegoPino
    
    - Add checkbox for version overriding in favour of not
        clearing version field for newest licenses
    - Support '#required'
    - Refrain from using `$form_state['input']` entirely
    - Remove "cache" (and related functions), but use temporary
        storage to prevent re-requesting the API
    - Move common code of the two API callers into helper
        function
    - Issue `form_set_value()`
    - Remove unnecessary `$input` parameter in
        `xml_form_elements_creative_commons_get_processed_values()`
    - Hide technical warning when no license output is selected
    - Improve behaviour for manually entered URIs (in particular,
        if a known license is entered with up-to-date version,
        unset version overriding)
    
    * Remove PHP 5.5+ syntax
    
    * Improve error message on unknown jurisdiction in manual mode
    
    Also, improve consistency for newly introduced temporary variable.
    
    * Mend the license type description for none vs. some license
    
    * Correct typo in regular expression
    
    * Address @DiegoPino's code review
    
    - Adjust return value code documentation for the two deprecated
        functions
    - Add "Known Issues" sub-sub-section in `README.md` to document
        the CC API bug for Finish CC licenses
Commits on Jun 8, 2018
  1. ISLANDORA-877: Prevent visible empty div for datepicker element

    d-r-p committed Jun 8, 2018
    Add `display: none;` to datepicker CSS to hide it on page load.
Commits on Apr 12, 2018
  1. Merge pull request #251 from uml-digitalinitiatives/7.x-ISLANDORA-2192

    bondjimbond committed Apr 12, 2018
    Set #tree == TRUE if no #value and no $form_state['disabled'] set.
Commits on Apr 11, 2018
  1. Missing a space.

    whikloj committed Apr 11, 2018
  2. Hide elements correctly.

    whikloj committed Apr 11, 2018
    Use international as default.
Commits on Apr 10, 2018
  1. Fix typo

    whikloj committed Apr 10, 2018
Commits on Apr 9, 2018
Commits on Mar 31, 2018
  1. Merge pull request #250 from uml-digitalinitiatives/7.x-ISLANDORA-2173

    bondjimbond committed Mar 31, 2018
    Make Creative Commons license optional
Commits on Mar 29, 2018
  1. Allow disable cc license.

    whikloj committed Mar 29, 2018
Commits on Mar 20, 2018
  1. ISLANDORA-2115: Add breadcrumbs (#248)

    bondjimbond authored and DiegoPino committed Mar 20, 2018
    * Add breadcrumbs
    
    * Coding standards
    
    * Add Islandora admin to breadcrumbs
Commits on Mar 11, 2018
  1. Merge pull request #247 from d-r-p/7.x-ISLANDORA-2140

    rosiel committed Mar 11, 2018
    ISLANDORA-2140: Prevent garbled MODS when going back and forth in ingest forms
Commits on Mar 6, 2018
  1. Conform to Islandora coding standards (pt.2)

    d-r-p committed Mar 6, 2018
    Change "do {\n...}\nwhile (...);\n" into "do {\n...} while (...);\n".
  2. Conform to Islandora coding standards

    d-r-p committed Mar 6, 2018
    Change indentation, as well as line lengths of comments.
Commits on Feb 28, 2018
  1. Addresses ISLANDORA-2140

    d-r-p committed Feb 28, 2018
    When creating an XML fragment, adjust the DOMNode to register
    and update the FormElement's value.
Commits on Feb 2, 2018
Commits on Nov 2, 2017
  1. Merge pull request #244 from DiegoPino/7.x-ISLANDORA-2105

    jordandukart committed Nov 2, 2017
    ISLANDORA-2105: Fix CMODEL associations when default transforms are enabled
Commits on Oct 31, 2017
Commits on Sep 17, 2017
  1. Merge pull request #230 from ajstanley/7.x

    rosiel committed Sep 17, 2017
    added ability to edit associations
Commits on Sep 12, 2017
  1. Merge pull request #243 from DiegoPino/7.x-ISLANDORA-2053

    whikloj committed Sep 12, 2017
    ISLANDORA-2053: Update travis.yml to force PHP 5.3.3 to run under Ubuntu Precise
Commits on Jul 27, 2017
Commits on Apr 10, 2017
  1. Merge pull request #241 from aulorbe/patch-1

    manez committed Apr 10, 2017
    ISLANDORA-1698 - update CONTRIBUTING.md
Commits on Apr 7, 2017
Commits on Apr 6, 2017
  1. moved brace

    ajstanley committed Apr 6, 2017
  2. formatting

    ajstanley committed Apr 6, 2017
Commits on Mar 16, 2017
  1. Merge pull request #240 from nmader/7.x-ISLANDORA_XML-1880

    rosiel committed Mar 16, 2017
    7.x islandora xml 1880
Commits on Mar 2, 2017