Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #9

Merged
merged 19 commits into from Dec 10, 2014

Conversation

Projects
None yet
2 participants
@RobertBColton
Copy link
Collaborator

commented Dec 9, 2014

  1. Outlined resource handling class for i18n, image, and keyboard configuration.
  2. Replaced all copyright headers with the doxygen format because it allows us to describe each file, among other tings. All copyright names were simply copied over and I added the copyright header to my new class, please double check I updated the copyright headers correctly.
  3. Added tooltips to all buttons on the main toolbar.
  4. Added missing keyboard shortcuts to every menu item I could.
  5. Added translations everywhere I could.
  6. Improved the unsaved changes dialog to have Yes (opens a save dialog), No (closes without saving), Cancel (stops the program from closing)
  7. Added the missing edit menu where cut, copy, and paste should go in the future.
  8. Translated the tool panel as well.
  9. Added missing round rectangle tool (with the same arc width and height as GM) and the paintbrush tool suggested in #13
  10. Implemented frame preferences handler to remember the maximized state and bounds of the window, uses the key "org/jeie"
  11. Added a dialog that now asks for the size when creating a new image.
  12. Added a jar description and manifest for building the application jar.

JEIE Improvements

@RobertBColton

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 9, 2014

@IsmAvatar I am going to make a release after this is merged and add it to the Extra Packages page.
http://enigma-dev.org/docs/Wiki/Install:Extra_Packages
You should add a little more to the JEIE wiki page for me.
http://enigma-dev.org/docs/Wiki/Java_Easy_Image_Editor

Also, I used Resource.java as the class for handling i18n messages, icon, and accelerator keys. I think we should rename the LGM class from messages.java to Resource.java as well since it does similar. If we do that should we also move the LGM.getIconForKey method to that class like I've done for JEIE?

@RobertBColton RobertBColton changed the title Improvements *DO NOT MERGE* Improvements Dec 9, 2014

@RobertBColton

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 10, 2014

@IsmAvatar I have made a release with the fixes and changes made in this pull request, so I am going to request that you merge this and then I'll start on the next version.
http://enigma-dev.org/forums/index.php?topic=2362

@IsmAvatar

This comment has been minimized.

Copy link
Owner

commented Dec 10, 2014

I've upgraded you to a Collaborator, so you should be able to commit directly now and/or merge your own pull requests.

IsmAvatar added a commit that referenced this pull request Dec 10, 2014

@IsmAvatar IsmAvatar merged commit 510fca2 into IsmAvatar:master Dec 10, 2014

@RobertBColton

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 10, 2014

@IsmAvatar Haha, thanks, but I will still be tagging you every so often to make sure I don't screw anything up, I am trying to go the less conflicting route here, just focusing on small improvements before major changes, same conservative approach I've traditionally taken to LGM.

Old IsmAvatar had a repo, and in that repo she had some Java code, J-E-I-E-I-O!!!

@IsmAvatar

This comment has been minimized.

Copy link
Owner

commented Dec 10, 2014

Of course. Glad to review anything you feel needs it.

And yes, I often find myself saying J.E.I.E.I.O or J-j-j-jia (which is the actual pronunciation by the way, "jia")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.