Backgrounds imported from GM5 don't have their "use as tileset" flag set correctly. #144

Closed
sorlok opened this Issue Sep 4, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@sorlok
Contributor

sorlok commented Sep 4, 2014

Game Maker 5 did not have the "use as tileset" background property, so importing a GMD file will lead to all backgrounds being considered "not tilesets". Although this is a good default, there is another option: scan the rooms and set "use as tileset" for all backgrounds a room specifically lists as a tileset. (This will not fix tiles added through tile_add().)

This is really a judgement call; the only reason it matters (to me) is that it prevents you editing GM5 maps. If you try to select a tile and then click on the map, the entire background image is place into the map.

A simpler workaround would be to leave the "use as tileset" flag unchanged, but modify the room editor to place tiles even if that flag is off. I am not really clear on all the use cases of tilesets vs. normal backgrounds appearing as-is, but I thought I should post this bug report at least.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Sep 4, 2014

Collaborator

I like the former and it should definitely be implemented.

Collaborator

RobertBColton commented Sep 4, 2014

I like the former and it should definitely be implemented.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Sep 9, 2014

Collaborator

@sorlok I would like some additional details. First of all what does GM6/7/8/Studio do about this? Second I do not know about at runtime whether ENIGMA blocks backgrounds that aren't tile sets from being placed.

Collaborator

RobertBColton commented Sep 9, 2014

@sorlok I would like some additional details. First of all what does GM6/7/8/Studio do about this? Second I do not know about at runtime whether ENIGMA blocks backgrounds that aren't tile sets from being placed.

@sorlok

This comment has been minimized.

Show comment
Hide comment
@sorlok

sorlok Sep 9, 2014

Contributor

I'll look into the first point.

Regarding the second, ENIGMA will, at runtime, still process tiles correctly. In fact, this issue only affects the viewing and editing of these maps; if they are compiled into ENIGMA then they will run without error.

Contributor

sorlok commented Sep 9, 2014

I'll look into the first point.

Regarding the second, ENIGMA will, at runtime, still process tiles correctly. In fact, this issue only affects the viewing and editing of these maps; if they are compiled into ENIGMA then they will run without error.

@sorlok

This comment has been minimized.

Show comment
Hide comment
@sorlok

sorlok Oct 6, 2014

Contributor

Ok, after doing some digging, GM8 and GM:S don't bother setting the "use as tileset" flag, even if it is clear that the background in question is being used as a tileset. Both will render the maps correctly, but editing them is impossible until the "use as" flag is set.

I'm going to make a patch to auto-detect backgrounds which are used as tilesets when upgrading from GM5/6.

Contributor

sorlok commented Oct 6, 2014

Ok, after doing some digging, GM8 and GM:S don't bother setting the "use as tileset" flag, even if it is clear that the background in question is being used as a tileset. Both will render the maps correctly, but editing them is impossible until the "use as" flag is set.

I'm going to make a patch to auto-detect backgrounds which are used as tilesets when upgrading from GM5/6.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Oct 6, 2014

Collaborator

@sorlok, Alrighty that sounds fine, I'll review and pull the fix when it's available!

Collaborator

RobertBColton commented Oct 6, 2014

@sorlok, Alrighty that sounds fine, I'll review and pull the fix when it's available!

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Oct 7, 2014

Collaborator

This issue is resolved as of #154

Collaborator

RobertBColton commented Oct 7, 2014

This issue is resolved as of #154

@sorlok

This comment has been minimized.

Show comment
Hide comment
@sorlok

sorlok Oct 7, 2014

Contributor

Thanks again for your help in testing this.

Contributor

sorlok commented Oct 7, 2014

Thanks again for your help in testing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment