Action List Operations #165

Open
RobertBColton opened this Issue Nov 9, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@RobertBColton
Collaborator

RobertBColton commented Nov 9, 2014

When you delete an action, the frame is not closed. This is not a regression and exists in lgm16b4
There are two ways to look at this problem. The user may accidentally delete the action but want to save the action contents. But if we continue to allow the frame to remain open the user may also not notice and continue coding only to find out that their changes are gone. So this is a double edged sword, and fixing it seems to involve choosing the lesser of two evils. However it is also possible that when removing actions from the list we could check to see if they have open frames and warn the user if they want to continue or if they would like to close the frame, I would rather go with a message similar to the latter.

Now another issue to discuss is with the new undo manager for action lists. What exactly should happen if the user performs an undo operation while the action frame is open? Similar to before we can also warn the user and ask if they want to commit changes to the action frame and whether to close the frame before they are allowed to continue the undo operation.

@RobertBColton RobertBColton changed the title from Deleting Actions to Action List Operations Nov 9, 2014

@IsmAvatar

This comment has been minimized.

Show comment
Hide comment
@IsmAvatar

IsmAvatar Nov 9, 2014

Owner

I thought the Frame was modal. Has that been removed?
To answer the question, though, the behavior should not be any more intrusive than when you delete a Resource with the Resource Frame still open.

Owner

IsmAvatar commented Nov 9, 2014

I thought the Frame was modal. Has that been removed?
To answer the question, though, the behavior should not be any more intrusive than when you delete a Resource with the Resource Frame still open.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Nov 9, 2014

Collaborator

@IsmAvatar GM makes their action frames modal, however in Studio they made the code actions not modal assuming the user may want more than one open side by side, GM8.1 has a modal code action window. I do not favor modal action windows at all, and I agree with you. I have thoroughly tested this in many different ways and this is the only real problem with having the action dialogs non modal. Studio actually keeps the non-code actions modal because their system is not as robust as LateralGM's.

An example test case that works:

  1. Create a new sprite
  2. Create an object
  3. Add a draw sprite action and set the sprite
  4. Without closing the action frame, delete the sprite in the background
  5. Combobox on the action frame automatically updates to

So the system is already pretty robust, and this issue is a minor one that we can find a way to resolve it as I suggest above.

Collaborator

RobertBColton commented Nov 9, 2014

@IsmAvatar GM makes their action frames modal, however in Studio they made the code actions not modal assuming the user may want more than one open side by side, GM8.1 has a modal code action window. I do not favor modal action windows at all, and I agree with you. I have thoroughly tested this in many different ways and this is the only real problem with having the action dialogs non modal. Studio actually keeps the non-code actions modal because their system is not as robust as LateralGM's.

An example test case that works:

  1. Create a new sprite
  2. Create an object
  3. Add a draw sprite action and set the sprite
  4. Without closing the action frame, delete the sprite in the background
  5. Combobox on the action frame automatically updates to

So the system is already pretty robust, and this issue is a minor one that we can find a way to resolve it as I suggest above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment