Action List Focus Policy/DND #171

Open
egofree71 opened this Issue Nov 11, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@egofree71
Collaborator

egofree71 commented Nov 11, 2014

Within the objects window, if the actions list panel doesn't have the focus, the keyboards shortcuts don't work.
To reproduce the problem : just open a new objects window, and add directly new actions. It will not work. You have to select an action in the actions list panel.

@egofree71 egofree71 changed the title from Undo not working correctly in the actions list if the actions list does not have the focus to Undo is not working correctly in the actions list if the actions list does not have the focus Nov 11, 2014

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Nov 12, 2014

Collaborator

@egofree71 Partially fixed in 8209ec7
http://enigma-dev.org/forums/index.php?topic=2269.msg23829#new

Move still does not maintain selection as it used to.

Collaborator

RobertBColton commented Nov 12, 2014

@egofree71 Partially fixed in 8209ec7
http://enigma-dev.org/forums/index.php?topic=2269.msg23829#new

Move still does not maintain selection as it used to.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Dec 10, 2014

Collaborator

@egofree71 This is still a different issue as far as the focus, we plan on adding cut/copy/paste and transferring of events between object frames, so which should get the focus by default? The action list or the event tree?

Collaborator

RobertBColton commented Dec 10, 2014

@egofree71 This is still a different issue as far as the focus, we plan on adding cut/copy/paste and transferring of events between object frames, so which should get the focus by default? The action list or the event tree?

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Sep 22, 2015

Collaborator

Even with all of the above features now added. This is not that big of an issue, because it also exists in GM: Studio as I just tested in 1.4 the latest version and it also exists in every Swing program I can find. Tested GM 8.1 and it's the same problem there too. In fact, in every way I can test LGM it is behaving exactly the same as GM8.1 and GM: Studio and many other programs I've tested with drag and drop functionality. If you click the action list and focus it, then drag and drop an action, the list still has focus and the key events work, like I said, in every way I can think of, it works.
https://docs.oracle.com/javase/tutorial/uiswing/examples/dnd/

I sort of consider this a general UI bug everywhere because if you check the official drag and drop demo's for Java too, dragging into a text area gives it focus but dragging onto a list does not give it focus. I can say that I believe a nice solution to this problem is to make the action list request focus when a DND tile is dropped on it. We can not make cut/copy/paste be attached to the whole editor because it should also work for the selected events (though I notice we have not added these shortcuts) it should also work for the name text field, so it cannot be global to the whole object frame.

@egofree71 I've gone through all of the Qt DND examples and they have the same issue, the list you drag from keeps the keyboard focus. So I'll have to test native Windows Forms and see if this is also the case. This really bothers me because all text controls grab focus once you drop into them.
QT DND

While this may sound counter-intuitive, there may be people who want to insert to the action list from the drag and drop panel with the keyboard and keep the tabs in focus, GM don't allow this. It seems counter-intuitive because who would want to use the keyboard for "drag and dropping" which you know, implies dragging with the mouse. So I am not really sure what to do, though we are able to change the behavior since this is our own control.

Collaborator

RobertBColton commented Sep 22, 2015

Even with all of the above features now added. This is not that big of an issue, because it also exists in GM: Studio as I just tested in 1.4 the latest version and it also exists in every Swing program I can find. Tested GM 8.1 and it's the same problem there too. In fact, in every way I can test LGM it is behaving exactly the same as GM8.1 and GM: Studio and many other programs I've tested with drag and drop functionality. If you click the action list and focus it, then drag and drop an action, the list still has focus and the key events work, like I said, in every way I can think of, it works.
https://docs.oracle.com/javase/tutorial/uiswing/examples/dnd/

I sort of consider this a general UI bug everywhere because if you check the official drag and drop demo's for Java too, dragging into a text area gives it focus but dragging onto a list does not give it focus. I can say that I believe a nice solution to this problem is to make the action list request focus when a DND tile is dropped on it. We can not make cut/copy/paste be attached to the whole editor because it should also work for the selected events (though I notice we have not added these shortcuts) it should also work for the name text field, so it cannot be global to the whole object frame.

@egofree71 I've gone through all of the Qt DND examples and they have the same issue, the list you drag from keeps the keyboard focus. So I'll have to test native Windows Forms and see if this is also the case. This really bothers me because all text controls grab focus once you drop into them.
QT DND

While this may sound counter-intuitive, there may be people who want to insert to the action list from the drag and drop panel with the keyboard and keep the tabs in focus, GM don't allow this. It seems counter-intuitive because who would want to use the keyboard for "drag and dropping" which you know, implies dragging with the mouse. So I am not really sure what to do, though we are able to change the behavior since this is our own control.

@RobertBColton RobertBColton changed the title from Undo is not working correctly in the actions list if the actions list does not have the focus to Action List Focus Policy/DND Sep 22, 2015

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Apr 12, 2016

Collaborator

I just finished testing Construct and the "Add Event" options on its toolbar does give it's version of an action list keyboard focus. Stencyl is written in some esoteric and fundamentally flawed Java GUI framework (like all the others) so ofc it doesn't give keyboard focus, it doesn't even show focused buttons.

Construct 2 Drag & Drop

Collaborator

RobertBColton commented Apr 12, 2016

I just finished testing Construct and the "Add Event" options on its toolbar does give it's version of an action list keyboard focus. Stencyl is written in some esoteric and fundamentally flawed Java GUI framework (like all the others) so ofc it doesn't give keyboard focus, it doesn't even show focused buttons.

Construct 2 Drag & Drop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment