Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Changing code text, reverting, and visiting another event causes the reverted state to be restored #2
Steps to reproduce:
Observed behavior: Contents reflect State 2
This seems to be caused by the wrong state being chosen despite the revert, and further seems to depend on the ActionList being flushed.
added a commit
Apr 21, 2012
Fixed in ff5628a. The issue was caused by rejected action frames being kept in memory and then committed during ActionList context switch. The solution was pretty much to only commit actions whose windows are still open. I'm not sure when it sprang up, but it may have been when I made ActionFrames part of the modular frame system.
More interesting, however, is that there seems to be a lot of code to allow ActionFrames to float around simultaneous of other ongoing modifications of other actions and objects, even though ActionFrames are modal. This is a lot of extra code that isn't being put to use, and this should be investigated - either to put the code to use (by making AcitonFrames non-modal) or by eliminating it. I digress, though - this bug is solved, I got what I came here for.