New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Tree Doesn't Discriminate Double Clicks #32

Closed
JoshDreamland opened this Issue Jan 3, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@JoshDreamland

JoshDreamland commented Jan 3, 2013

  1. Select a resource in the tree, but do not open it.
  2. Hover over the [+](or swing-themed replacement thereof) next to a different resource group as if to expand it.
  3. Double click it.

LGM will receive the double click from the tree and open the selected resource, which will not have changed since you double clicked the widget that toggles group display.

Also, an ENIGMA-related bug that is made worse by this is: A new syntax check button is added to the script windows every time you do this. And every time you attempt to open it a second time normally.

@dazappa

This comment has been minimized.

Show comment
Hide comment
@dazappa

dazappa Jan 9, 2013

Contributor

This bug should be fixed in #34 / #36, aside from the ENIGMA-related bug.

Contributor

dazappa commented Jan 9, 2013

This bug should be fixed in #34 / #36, aside from the ENIGMA-related bug.

@IsmAvatar

This comment has been minimized.

Show comment
Hide comment
@IsmAvatar

IsmAvatar May 23, 2013

Owner

This bug persists in d93ebbad, which either means it was not corrected in the pull request or 34/36, or else it regressed.
Marking as reproducible. Also, this is able to be reproduced by double clicking empty space in the resource tree as well.

Note to the person who codes the fix: This is not hard to track down, as this behavior was originally "intended". The tree was one of the very first widgets that I wrote for LGM, without much understanding of Java widgets, so this is simply the way I implemented double click. I'm sure there's better ways of doing it, I just didn't know them at the time I implemented this, so I just did the best I could, which meant this particular piece of undesirable behavior fell through the cracks, and should be fairly easy to fix.

Owner

IsmAvatar commented May 23, 2013

This bug persists in d93ebbad, which either means it was not corrected in the pull request or 34/36, or else it regressed.
Marking as reproducible. Also, this is able to be reproduced by double clicking empty space in the resource tree as well.

Note to the person who codes the fix: This is not hard to track down, as this behavior was originally "intended". The tree was one of the very first widgets that I wrote for LGM, without much understanding of Java widgets, so this is simply the way I implemented double click. I'm sure there's better ways of doing it, I just didn't know them at the time I implemented this, so I just did the best I could, which meant this particular piece of undesirable behavior fell through the cracks, and should be fairly easy to fix.

@IsmAvatar

This comment has been minimized.

Show comment
Hide comment
@IsmAvatar

IsmAvatar May 23, 2013

Owner

Nevermind. d93ebbad is an enigma-dev revision which includes an older version of LGM before the pull. Tested in 289d246 and the behavior is correct, so the pull request fixed it.

Owner

IsmAvatar commented May 23, 2013

Nevermind. d93ebbad is an enigma-dev revision which includes an older version of LGM before the pull. Tested in 289d246 and the behavior is correct, so the pull request fixed it.

@IsmAvatar IsmAvatar closed this May 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment