Spaces in resource names causes issues (e.g. name erasure) #7

Closed
IsmAvatar opened this Issue Jan 23, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@IsmAvatar
Owner

IsmAvatar commented Jan 23, 2012

Steps to reproduce:

Part 1: Produce a file with a resource with a space in its name

  1. Open Game Maker
  2. Create any resource
  3. Name the resource with a space in its name, such as "sprite 0"
  4. Save the file

Part 2: Open a file that contains a resource with a space in its name.

  1. Open LGM, and open the file created in part 1
  2. Locate and attempt to edit the resource that has a space in its name.

Observed behavior: The resource editor opens with an empty resource name. Saving the resource causes the name to be erased.
Desired behavior: The space should either be converted at some point (probably on load) or preserved.

The desired behavior here is not clear. There should probably be a consensus before we move forward.

It is worth noting that Game Maker's behavior is to preserve spaces.

Additionally note: Preserving spaces will not allow the resources to be used in scripts unless a string resolver is used. Converting spaces may cause issues with string-resolved names. No known string resolvers exist at this time (execute_string does not resolve resource names with spaces).

@rpjohnst

This comment has been minimized.

Show comment
Hide comment
@rpjohnst

rpjohnst Jan 26, 2012

Contributor

Resources with spaces in their name are still accessible through GUI menus such as the object's sprite or an action's context. These do work already in LGM, so the desired behavior is probably to preserve the spaces.

Contributor

rpjohnst commented Jan 26, 2012

Resources with spaces in their name are still accessible through GUI menus such as the object's sprite or an action's context. These do work already in LGM, so the desired behavior is probably to preserve the spaces.

@IsmAvatar

This comment has been minimized.

Show comment
Hide comment
@IsmAvatar

IsmAvatar Apr 21, 2012

Owner

Commit 40bbb1 now allows spaces in resource names.

Owner

IsmAvatar commented Apr 21, 2012

Commit 40bbb1 now allows spaces in resource names.

@IsmAvatar IsmAvatar closed this Apr 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment