Negative Model Selections #93

Closed
RobertBColton opened this Issue Sep 12, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@RobertBColton
Collaborator

RobertBColton commented Sep 12, 2013

Sometimes -1 shows up as the selection from some tree models and list models. Like for instance pressing ALT + ResNode toggles selection on an item and you can make the tree have no selected item, and then if you hit any of the add resource buttons on the toolbar, they won't do anything. Checks need implemented in various places where these item models can be negative and ensure the proper action is taken.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Feb 10, 2014

Collaborator

I have partially resolved the issue with the add resource options in LateralGM 1.8.4, the issue stemmed from ambiguity in the add and insert resource code. Sitting here thinking though, I can't think of any specific editors that will have issues with negative model selections as noone has reported an issue, but I want to point the finger at #29 because I addressed a similar bug way back when I started on LGM and my experience then may have caused me to resolve the issue incorrectly.

Collaborator

RobertBColton commented Feb 10, 2014

I have partially resolved the issue with the add resource options in LateralGM 1.8.4, the issue stemmed from ambiguity in the add and insert resource code. Sitting here thinking though, I can't think of any specific editors that will have issues with negative model selections as noone has reported an issue, but I want to point the finger at #29 because I addressed a similar bug way back when I started on LGM and my experience then may have caused me to resolve the issue incorrectly.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Apr 28, 2014

Collaborator

This ticket remains open because there are several other places in LGM where negative model selections can potentially throw NPE's, like egofree just discovered in the tree and I fixed in 5c9b35d

Collaborator

RobertBColton commented Apr 28, 2014

This ticket remains open because there are several other places in LGM where negative model selections can potentially throw NPE's, like egofree just discovered in the tree and I fixed in 5c9b35d

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Sep 30, 2014

Collaborator

I have fixed two more similar exceptions that were the result of @egofree71 but they were just slight mistakes in 590646f and 64c7adb

I am going to close this ticket as the bulk of these OOB's over the course of LGM's history have been resolved especially thanks to our exception dialog, I just want to stress that these get tested better before committing in the future.

Collaborator

RobertBColton commented Sep 30, 2014

I have fixed two more similar exceptions that were the result of @egofree71 but they were just slight mistakes in 590646f and 64c7adb

I am going to close this ticket as the bulk of these OOB's over the course of LGM's history have been resolved especially thanks to our exception dialog, I just want to stress that these get tested better before committing in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment