Fixes PathEditor Visuals #237

Merged
merged 1 commit into from Jan 23, 2016

Conversation

Projects
None yet
1 participant
@RobertBColton
Collaborator

RobertBColton commented Jan 23, 2016

The path editor had a number of problems introduced in 22c2e6e that I describe in #231. After running it by @rpjohnst we decided to change the HashMap's to IdentityHashMap with reference equality. This is typically what is intended when objects are used as keys in a HashMap. The path editor now behaves properly again as it did in the original 16b4 release.

We failed greatly with using regular expressions to find out how to break the line:

final IdentityHashMap<PathPoint,SmoothPathSegment> spsMap = new IdentityHashMap<PathPoint,SmoothPathSegment>();

Eventually we settled on:

final IdentityHashMap<PathPoint,SmoothPathSegment> spsMap =
        new IdentityHashMap<PathPoint,SmoothPathSegment>();
Fixes PathEditor Visuals
The path editor had a number of problems introduced in 22c2e6e that I
describe in #231. After running it by @rpjohnst we decided to change the
HashMap's to IdentityHashMap with reference equality. This is typically
what is intended when objects are used as keys in a HashMap. The path
editor now behaves properly again as it did in the original 16b4 release.

RobertBColton added a commit that referenced this pull request Jan 23, 2016

@RobertBColton RobertBColton merged commit e6e4427 into IsmAvatar:16b5 Jan 23, 2016

@RobertBColton RobertBColton referenced this pull request Jan 29, 2016

Merged

1.8.7 changes #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment