Implements Find Resource feature #242

Merged
merged 2 commits into from Jan 28, 2016

Conversation

Projects
None yet
2 participants
@RobertBColton
Collaborator

RobertBColton commented Jan 27, 2016

In 16b4 the menu item was added but was never made to do anything. This implements the same feature from GM8.1 exactly. It can find every resource which is not a group including game info and settings. By this I mean typing "Game Information" will open game info, it does not do so in GM8.1, GM only let's you find secondary resource nodes. Another difference is that I made the LGM version expand the tree path and highlight the node in the tree (Rusky prefers this), GM does not do this and will leave the parent node of the resource collapsed and still open the frame. In GM8.1 the "Not Found" message is a generic message, I opted to make it a warning for LGM (Rusky has no preference). It is also case sensitive like GM8.1.

Find resource

French translations are again provided by @egofree. Titles are not capitalized the same because he found it odd to capitalize them like the English version. This is also the case with the Windows OS where "Control Panel" is not all capitalized in the French version. LGM was also following this convention elsewhere with dialogs such as "Help->About" and "Resources->Defrag Ids." For these reasons, I went with the version originally provided by egofree since that came most naturally to him as a native speaker of French.
French Windows Control Panel

RobertBColton added some commits Jan 27, 2016

Implements Find Resource feature
In 16b4 the menu item was added but was never made to do anything. This
implements the same feature from GM8.1 exactly. It can find every resource
which is not a group including game info and settings. By this I mean
typing "Game Information" will open game info, it does not do so in GM8.1,
GM only let's you find secondary resource nodes. It is also case sensitive
like GM8.1.
Updates French translation.
Adds the translations for the resource find dialog by @egofree.

RobertBColton added a commit that referenced this pull request Jan 28, 2016

Merge pull request #242 from RobertBColton/16b5
Implements Find Resource feature

@RobertBColton RobertBColton merged commit e8ba181 into IsmAvatar:16b5 Jan 28, 2016

@JoshDreamland

This comment has been minimized.

Show comment
Hide comment
@JoshDreamland

JoshDreamland Jan 29, 2016

Imho, it is worth effort on both of our parts to merge the tree filter in. I wrote some of the code behind it, anyway, so perhaps my opinion is biased. I did have some issue with the way it created tabs in the tree pane; it might be best to exclude those changes. Either way, we can deal with this tonight.

Imho, it is worth effort on both of our parts to merge the tree filter in. I wrote some of the code behind it, anyway, so perhaps my opinion is biased. I did have some issue with the way it created tabs in the tree pane; it might be best to exclude those changes. Either way, we can deal with this tonight.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Jan 29, 2016

Collaborator

@JoshDreamland I am certain it can be done without extra tabs like it is in Unity3D. We'll have to table that for now though because I want something modular and to make it a clean implementation unlike the last one. Also like Nautilus/Windows Explorer, just show the results right there.

Collaborator

RobertBColton commented Jan 29, 2016

@JoshDreamland I am certain it can be done without extra tabs like it is in Unity3D. We'll have to table that for now though because I want something modular and to make it a clean implementation unlike the last one. Also like Nautilus/Windows Explorer, just show the results right there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment