Implements missing game settings #244

Merged
merged 8 commits into from Jan 31, 2016

Conversation

Projects
None yet
1 participant
@RobertBColton
Collaborator

RobertBColton commented Jan 28, 2016

This adds the missing setting for treating the close button as the escape key to the game settings frame as well as the version, copyright, product, and description settings on the same tab. The settings were already being read and written by the GMK reader/writer but were just not placed on the frame. It is important to note that the game settings frame is broken in 16b4 and still has not been fixed, so opening the frame always shows the default settings.

@rpjohnst or @JoshDreamland decided they like the GroupLayout version because of the additional padding and the side effect it has on the tabs. Important to note the side effect does not occur with the French version, likely because of the fonts.

I can do it as I have it with a GridBagLayout:
Missing Preferences

I can also do it with a GroupLayout which is a few lines less and automatically computes the padding. GroupLayout is more consistent with what the frame uses elsewhere as well.
Missing Preferences

RobertBColton added some commits Jan 28, 2016

Implements missing game setting for close button
This adds the missing setting for treating the close button as the escape
key to the game settings frame. The setting was already being read and
written by the GMK reader/writer but was just not placed on the frame. I
have tested saving and loading the setting in GM8.1 and it works as
expected.
Fixes alignment and translation
Makes the label alignment trailing instead of leading on the project
information tab, like it is in GM8.1. Also adds colons to the end of the
labels to make it look more presentable.
Revert layout changes
They are not needed for b5, and Rusky thinsk the old way was better so all
the labels are aligned. I agree with him and I like it the way LGM was.
Adds missing version and copyright preferences
Under the other tab, settings for revision number and company, copyright,
product, and description.
Limit columns
Limit the number of columns to 4 instead of changing min/max.

@RobertBColton RobertBColton changed the title from Implements missing game setting for close button to Implements missing game settings Jan 29, 2016

RobertBColton added some commits Jan 31, 2016

Uses group layout instead
Josh and Rusky like the side effects of the extra padding using a
GroupLayout so that's what I'm going with. The GL version is also more
straightforward. Adds teh French translations by egofree as well.

RobertBColton added a commit that referenced this pull request Jan 31, 2016

Merge pull request #244 from RobertBColton/16b5
Implements missing game settings

@RobertBColton RobertBColton merged commit 641d3dd into IsmAvatar:16b5 Jan 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment