New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sound editor and formatting in another source file #256

Merged
merged 2 commits into from Mar 21, 2016

Conversation

Projects
None yet
1 participant
@RobertBColton
Collaborator

RobertBColton commented Mar 21, 2016

This fixes an issue with the sound editor.

  1. Create a new sound and load a playable wav
  2. Start playing/preview the wav in the sound editor
  3. While it is still playing, load an MP3, which is not playable
  4. The play button is still enabled
  5. Attempt to play the mp3, and encounter an exception

RobertBColton added some commits Mar 21, 2016

Fix sound editor glitch for unsupported formats
There was a glitch where if you loaded a playable sound file, like a wav,
then played it and loaded an unplayable file, like an mp3, while it was
still playing, the play button would be enabled for an unsupported file
format.

RobertBColton added a commit that referenced this pull request Mar 21, 2016

Merge pull request #256 from RobertBColton/master
Fix sound editor and formatting in another source file

@RobertBColton RobertBColton merged commit 2455a8b into IsmAvatar:master Mar 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment