Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.15 & master: One-on-one calls fail with "unsupported browser" message #55

Closed
theangryangel opened this Issue Mar 12, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@theangryangel
Copy link

theangryangel commented Mar 12, 2019

First off, thank you for working on this. I really do appreciate it.

Unfortunately with both v0.1.15 and master one-on-one calls to other users results in the message;

Try a different browser
This feature isn’t available yet for your browser. Try the web app with Microsoft Edge or Google Chrome, or switch to the desktop app.

Unfortunately, I think the fix for #21 is causing the problem. I have verified that adding the missing angular.element(document).injector().get('callingSupportService').oneOnOneCallingEnabled = true; from #21 does not fix the issue, but I've not yet had the time to dig in further.

I'll try and see if I have time at some point in the next few days. Figured I'd create the issue just incase someone's already on it?

@theangryangel theangryangel changed the title v0.1.15: One-on-one calls fail with "unsupported browser" message v0.1.15 & master: One-on-one calls fail with "unsupported browser" message Mar 12, 2019

@julian-alarcon

This comment has been minimized.

Copy link
Collaborator

julian-alarcon commented Mar 12, 2019

I confirm this issue. Same version 0.1.15

@IsmaelMartinez

This comment has been minimized.

Copy link
Owner

IsmaelMartinez commented Mar 12, 2019

Could either of you try branch 0.1.16? There where a few extras that I missed in 0.1.15. apologies

@theangryangel

This comment has been minimized.

Copy link
Author

theangryangel commented Mar 12, 2019

Confirmed that 0.1.16 works great <3

No need to apologise at all Ismael! You're single-handedly doing the job Microsoft should be doing, and I cannot thank you enough.

@IsmaelMartinez

This comment has been minimized.

Copy link
Owner

IsmaelMartinez commented Mar 12, 2019

Thanks @theangryangel , 0.1.16 is on the making and hopefully we get desktop sharing in it thanks to the help of a few. Anything helps, from posting issues, asking for new features or, even better, fixing or implementing stuff!! Hopefully one day Microsoft will decide to support Linux properly and I can spend my time doing something else!

@IsmaelMartinez IsmaelMartinez referenced this issue Mar 14, 2019

Merged

0.1.16 #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.