Skip to content

Conversation

@Ayyanchira
Copy link
Member

🔹 Jira Ticket(s) if any

✏️ Description

Adds null check for inbox metadata. This was causing tester app to crash.

@Ayyanchira Ayyanchira requested review from Copilot and evantk91 July 29, 2025 22:21

This comment was marked as outdated.

…/IterableInboxAdapter.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Ayyanchira Ayyanchira requested a review from Copilot July 29, 2025 22:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds null safety checks for inbox metadata to prevent crashes in the tester app when metadata is unexpectedly null.

  • Adds null checks for inboxMetadata before accessing its properties
  • Provides fallback empty string for title when metadata or title is null
  • Prevents potential NullPointerException when loading icons with null metadata

Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and applied changes suggested by copilot.

@Ayyanchira Ayyanchira merged commit 59493b2 into master Jul 31, 2025
3 checks passed
@Ayyanchira Ayyanchira deleted the bugfix/inbox-metadata-null-check branch July 31, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants