Skip to content

Conversation

@joaodordio
Copy link
Member

@joaodordio joaodordio commented Sep 4, 2025

🔹 Jira Ticket(s)

✏️ Description

Renames a conflicting method name with the native CoreData one.
Versions older than iOS 15 will use the custom method, newer versions will use the native one.

Acknowledgements

Thank you @fnazarios and @rajusa420 for raising this issue!

@joaodordio joaodordio self-assigned this Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.17%. Comparing base (6e2fdec) to head (6e47cc0).
⚠️ Report is 888 commits behind head on master.

Files with missing lines Patch % Lines
swift-sdk/Internal/CoreDataUtil.swift 0.00% 1 Missing ⚠️
...ift-sdk/Internal/IterableCoreDataPersistence.swift 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #954       +/-   ##
===========================================
- Coverage   85.19%   70.17%   -15.03%     
===========================================
  Files          91      109       +18     
  Lines        6301    10044     +3743     
===========================================
+ Hits         5368     7048     +1680     
- Misses        933     2996     +2063     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joaodordio joaodordio merged commit e6a84f3 into master Sep 8, 2025
4 of 6 checks passed
@joaodordio joaodordio deleted the MOB-12033-Rename-CoreData-util-method-iOS-26-Compatibility branch September 8, 2025 10:14
@joaodordio joaodordio restored the MOB-12033-Rename-CoreData-util-method-iOS-26-Compatibility branch September 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants