Permalink
Browse files

Revert "Shared: Add DPI awareness manifest"

This reverts commit b5c3f14.
  • Loading branch information...
ensiform committed Nov 4, 2017
1 parent d60340b commit 1d125c7d15b6e91abe67a3de4e47e27f1406739d
Showing with 0 additions and 53 deletions.
  1. +0 −8 code/CMakeLists.txt
  2. +0 −8 codemp/CMakeLists.txt
  3. +0 −37 shared/sys/win_manifest.xml
View
@@ -416,14 +416,6 @@ if(BuildSPEngine OR BuildJK2SPEngine)
endif()
endif(MakeApplicationBundles)
# add DPI awareness manifest
if(MSVC)
add_custom_command(TARGET ${ProjectName} POST_BUILD
COMMAND "mt.exe" -manifest \"${SharedDir}\\sys\\win_manifest.xml\" -inputresource:\"$<TARGET_FILE:${ProjectName}>\"\;\#1 -outputresource:\"$<TARGET_FILE:${ProjectName}>\"\;\#1
COMMENT "Adding manifest..."
)
endif()
set_target_properties(${ProjectName} PROPERTIES COMPILE_DEFINITIONS "${SPEngineDefines}")
# Hide symbols not explicitly marked public.
View
@@ -577,14 +577,6 @@ if(BuildMPEngine)
endif(MakeApplicationBundles)
endif(WIN32)
# add DPI awareness manifest
if(MSVC)
add_custom_command(TARGET ${MPEngine} POST_BUILD
COMMAND "mt.exe" -manifest \"${SharedDir}\\sys\\win_manifest.xml\" -inputresource:\"$<TARGET_FILE:${MPEngine}>\"\;\#1 -outputresource:\"$<TARGET_FILE:${MPEngine}>\"\;\#1
COMMENT "Adding manifest..."
)
endif()
if(MakeApplicationBundles)
install(TARGETS ${MPEngine}
BUNDLE

This file was deleted.

Oops, something went wrong.

2 comments on commit 1d125c7

@ouned

This comment has been minimized.

Show comment
Hide comment
@ouned

ouned Nov 30, 2017

Contributor

why the revert? we use that in jk2mv without issues.

Contributor

ouned replied Nov 30, 2017

why the revert? we use that in jk2mv without issues.

@xycaleth

This comment has been minimized.

Show comment
Hide comment
@xycaleth

xycaleth Nov 30, 2017

Member

We were having issues where players couldn’t load the binary because of missing manifest. Local builds work, but not the ones deployed for some reason. Not sure why

Member

xycaleth replied Nov 30, 2017

We were having issues where players couldn’t load the binary because of missing manifest. Local builds work, but not the ones deployed for some reason. Not sure why

Please sign in to comment.