Use C++11-compliant string concatenation #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MSVC doesn't have a mode for either 11 or 14. It just is or it isn't depending on the version. AFAIK. |
C++11 reserves syntax like X"foo" and "foo"X for future syntax like L"a wide-char string", so concatenating macros with literals now requires an intervening space.
|
(pushed an updated version that does not include the commits from #658) |
Ah, OK, I'd misunderstood #651. In that case, the way to detect whether there's anything left to do is for @eezstreet to compile on whatever the relevant version is :-) |
xycaleth
added a commit
that referenced
this pull request
May 13, 2015
Use C++11-compliant string concatenation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
C++11 reserves syntax like X"foo" and "foo"X for future syntax like
L"a wide-char string", so concatenating macros with literals now
requires an intervening space. Fixes most, if not all, of #651.
Tested on Linux, so I could potentially have missed some instances of non-C++11-compliant concatenation in code specific to other platforms - compiling with MSVC in C++11 or C++14 mode would probably detect anything that's left.