Use same mechanism to say "no servers found" as to say how many we found #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids an array underflow: if no servers were found, we would write to foundPlayerServerNames[-1], which is undefined behaviour, but with a reasonable assumption of the stack layout is likely to result in a write to foundPlayerServerAddresses[MAX - 1].
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
Use same mechanism to say "no servers found" as to say how many we found Former-commit-id: e583559
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
Use same mechanism to say "no servers found" as to say how many we found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This avoids an array underflow: if no servers were found, we would
write to foundPlayerServerNames[-1], which is undefined behaviour, but
with a reasonable assumption of the stack layout is likely to result
in a write to foundPlayerServerAddresses[MAX - 1].
Underflow found via compiler warnings that are enabled by default in g++ 6.