savegames: bounds-check some string lengths to prevent buffer overflow #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcv
added a commit
to smcv/OpenJK
that referenced
this pull request
Jan 21, 2017
m_byBuffer is a pointer to a fixed amount of dynamically allocated memory, not a statically allocated buffer, so sizeof() is the wrong tool here. Use the actual size of the buffer instead. Also, reading the full size of the buffer is fine, because we aren't going to append '\0' afterwards like we do in the other places touched by JACoders#881, so use > instead of >=. Fixes JACoders#902 Signed-off-by: Simon McVittie <smcv@debian.org>
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
savegames: bounds-check some string lengths to prevent buffer overflow Former-commit-id: 60d9182
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
m_byBuffer is a pointer to a fixed amount of dynamically allocated memory, not a statically allocated buffer, so sizeof() is the wrong tool here. Use the actual size of the buffer instead. Also, reading the full size of the buffer is fine, because we aren't going to append '\0' afterwards like we do in the other places touched by JACoders#881, so use > instead of >=. Fixes JACoders#902 Signed-off-by: Simon McVittie <smcv@debian.org> Former-commit-id: fbf0dd0
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
savegames: bounds-check some string lengths to prevent buffer overflow
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
m_byBuffer is a pointer to a fixed amount of dynamically allocated memory, not a statically allocated buffer, so sizeof() is the wrong tool here. Use the actual size of the buffer instead. Also, reading the full size of the buffer is fine, because we aren't going to append '\0' afterwards like we do in the other places touched by JACoders#881, so use > instead of >=. Fixes JACoders#902 Signed-off-by: Simon McVittie <smcv@debian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a user loads a malicious saved game (perhaps posted on a forum or something), we don't want it to overflow or underflow the buffer.