snd_mem: fix build failure on big-endian CPUs with C++11 compilers #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Debian powerpc, mips and s390x builds failed with:
.../code/client/snd_mem.cpp: In function 'qboolean S_LoadSound_Actual(sfx_t*)':
.../code/client/snd_mem.cpp:843:54: error: invalid operands of types '__gnu_cxx::__enable_if<true, double>::__type {aka double}' and 'int' to binary 'operator>>'
if (sfx->fVolRange < (abs(sfx->pSoundData[i]) >> 8))
~~~~~~~~~~~~~~~~~~~~~~~~^~~~
.../code/client/snd_mem.cpp:845:50: error: invalid operands of types '__gnu_cxx::__enable_if<true, double>::__type {aka double}' and 'int' to binary 'operator>>'
sfx->fVolRange = abs(sfx->pSoundData[i]) >> 8;
~~~~~~~~~~~~~~~~~~~~~~~~^~~~
This appears to be because sfx->pSoundData[i] is of type short. C++98
only provided int abs(int), long abs(long), float abs(float),
double abs(double) and long double abs(long double) overloads, but
C++11 also provides double abs(T) for all integral types T, including
short. double is not a valid left-hand side for operator>> so
compilation fails.
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
snd_mem: fix build failure on big-endian CPUs with C++11 compilers Former-commit-id: b80d88a
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
snd_mem: fix build failure on big-endian CPUs with C++11 compilers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The Debian
powerpc,mipsands390xbuilds failed with:This appears to be because
sfx->pSoundData[i]is of typeshort. C++98only provided
int abs(int),long abs(long),float abs(float),double abs(double)andlong double abs(long double)overloads, butC++11 also provides
double abs(T)for all integral types T, includingshort.doubleis not a valid left-hand side foroperator>>socompilation fails.
Compile-tested on one of Debian's remote PowerPC servers. My own PowerPC is in storage, so I can't test this further for a while.