Incorrect selection paint when toAutoSpanColumns, toGridExtensions and toExtendedFocus are set

[vincentparrett]

From alexey.n...@mail.ru on December 25, 2012 18:50:30

What steps will reproduce the problem? 1. Set these three options in VT and add in tree three or more columns
2. Write OnGetText event handler. Assign to CellText empty string for 2nd column and non-empty string for 1st and 3rd column
3. Run project
4. First select the 1st column, then the 3rd column in same node What is the expected output? What do you see instead? After select 1st column, selection expands on 2nd column with empty text. This ok. But after select 3rd column, 2nd are stay selected. What version of the product are you using? On what operating system? VT r449 , Delphi2007, Win7Pro x64

Original issue: http://code.google.com/p/virtual-treeview/issues/detail?id=310

[vincentparrett]

From joachim....@gmail.com on December 31, 2012 06:05:50

Labels: -Priority-Medium Priority-Low

[vincentparrett]

From joachim....@gmail.com on January 09, 2014 12:19:01

Is this problem still present in V5.3.0?

Owner: joachim....@gmail.com

[vincentparrett]

From alexey.n...@mail.ru on January 09, 2014 22:24:00

Yes. In version 5.3.0 the problem remains.

Version 6.3
We are using the same setup and experiences the same problem + others; the problems seems to go away when adding the patch-snippet below in TBaseVirtualTree.HandleMouseDown. Note - all components in our applications uses toAutoSpanColumns/toGridExtensions/toExtendedFocus ie maybe the code-snippet should only run if certain conditions are meet:

// ...
  // Handle selection and node focus change.
  if (IsLabelHit or IsCellHit) and
     DoFocusChanging(FFocusedNode, HitInfo.HitNode, FFocusedColumn, Column) then
  begin
    if NewColumn then
    begin
      InvalidateColumn(FFocusedColumn);
      InvalidateColumn(Column);
      FFocusedColumn := Column;
      // patch
      if not NewNode and Assigned(HitInfo.HitNode) then
        InvalidateNode(HitInfo.HitNode);
      // /patch
    end;

This can be reproduced by making a few changes to GridDemo:

GridDemo.dfm - add the following

TreeOptions.AutoOptions = [..., toAutoSpanColumns]
TreeOptions.PaintOptions = [..., toAlwaysHideSelection]

(toAlwaysHideSelection is not strictly needed but shows the problem in a better way)

GridDemo.pas - change this procedure

procedure TGridForm.VST5GetText(Sender: TBaseVirtualTree; Node: PVirtualNode; Column: TColumnIndex; TextType: TVSTTextType; var CellText: UnicodeString);
begin
  // if Column > 0 then
  if (Column > 0) and (Column <> 2) then  
    CellText := Sender.GetNodeData<TGridData>(Node).Value[Column - 1]
  else
    CellText := '';
end;

First click Customer ID 2:

Now click on LastName on the same row:

[sanjayssk]

I just committed a fix. Please verify.

That solves the autospan issue...

Unfortunately there is another redraw bug when toGridExtensions + toExtendedFocus is used -
my internal-InvalidateNode-hack-patch solved that but I had completely forgotten about it - sorry.

If I click-select the MainColumn-cell (which has an icon):

Now click-select another cell:

What happens next is a bit strange:
If I click-select the same cell and moves the mouse a bit then all cells are cleared.
If a click-select another cell that cell is cleared (and sometimes all cells)...

[sanjayssk]

The first picture looks more like a fullrowselect so it's not clear what options you are using. Also, what do you mean by clear--clear the content or clear the selection? If you can give me the changes and the steps to recreate the problem in the grid demo similar to what you gave for the earlier problem, it will save my time in verifying the problem and your fix. Thanks.

The other issue is due to unrelated issues in our derived VT-class => this issue is fixed - thx!