From 12d5f1312852122a181344cd72c408e577da1f99 Mon Sep 17 00:00:00 2001 From: SmetDenis Date: Thu, 11 Apr 2024 13:36:50 +0400 Subject: [PATCH] Update benchmark setup in GitHub workflow and Makefile The GitHub workflow and Makefile have been updated for a better benchmark setup. A separate step for multi-threaded benchmarking has been added and the method of generating random integers in the CSV file has been altered. The adjustments provide a clearer understanding of the process and better use of resources. --- Dockerfile | 4 ++-- README.md | 4 ++-- action.yml | 4 ++-- src/Commands/AbstractValidate.php | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Dockerfile b/Dockerfile index a6a32c0a..b4aed754 100644 --- a/Dockerfile +++ b/Dockerfile @@ -54,5 +54,5 @@ RUN php ./docker/random-csv.php \ # Quick test RUN time ./csv-blueprint -V -#ENTRYPOINT ["/app/docker/entrypoint.sh"] -ENTRYPOINT ["/app/csv-blueprint"] +ENTRYPOINT ["/app/docker/entrypoint.sh"] +#ENTRYPOINT ["/app/csv-blueprint"] diff --git a/README.md b/README.md index 0cb03e9b..8d2d2da8 100644 --- a/README.md +++ b/README.md @@ -1466,7 +1466,7 @@ Options: --debug Intended solely for debugging and advanced profiling purposes. Activating this option provides detailed process insights, useful for troubleshooting and performance analysis. - -p, --parallel[=PARALLEL] EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel. + --parallel[=PARALLEL] EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel. You can specify the number of threads. If you do not specify a value, the number of threads will be equal to the number of CPU cores. By default, the process is launched in a single-threaded mode. [default: "1"] @@ -1526,7 +1526,7 @@ Options: --debug Intended solely for debugging and advanced profiling purposes. Activating this option provides detailed process insights, useful for troubleshooting and performance analysis. - -p, --parallel[=PARALLEL] EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel. + --parallel[=PARALLEL] EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel. You can specify the number of threads. If you do not specify a value, the number of threads will be equal to the number of CPU cores. By default, the process is launched in a single-threaded mode. [default: "1"] diff --git a/action.yml b/action.yml index 5c9b6088..8dfe230a 100644 --- a/action.yml +++ b/action.yml @@ -66,8 +66,8 @@ inputs: default: 'options: --ansi' runs: - using: docker - image: Dockerfile + using: 'docker' + image: 'docker://jbzoo/csv-blueprint' args: - validate:csv - '--csv' diff --git a/src/Commands/AbstractValidate.php b/src/Commands/AbstractValidate.php index 887d8216..d093cb09 100644 --- a/src/Commands/AbstractValidate.php +++ b/src/Commands/AbstractValidate.php @@ -81,7 +81,7 @@ protected function configure(): void ) ->addOption( 'parallel', - 'p', + null, InputOption::VALUE_OPTIONAL, \implode("\n", [ 'EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel.',