From ccdc38cddb14999085daebe940816bc8fe4c2e3c Mon Sep 17 00:00:00 2001 From: Masayuki Yamamoto <15698961+ma8ma@users.noreply.github.com> Date: Sun, 26 Jun 2022 21:03:41 +0900 Subject: [PATCH] BBSListViewBase: Fix duplicate if-coindition MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit if文の条件が繰り返し現れているとcppcheck 2.8に指摘されたため修正します。 cppcheckのレポート ``` src/bbslist/bbslistviewbase.cpp:403:17: style: Expression is always false because 'else if' condition matches previous condition at line 402. [multiCondition] else if( id == "popup_menu" ) menu_ui = popup_menu; ^ ``` --- src/bbslist/bbslistviewbase.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/bbslist/bbslistviewbase.cpp b/src/bbslist/bbslistviewbase.cpp index bd6411333..9b64cea99 100644 --- a/src/bbslist/bbslistviewbase.cpp +++ b/src/bbslist/bbslistviewbase.cpp @@ -400,7 +400,6 @@ const char* get_menu_ui( const std::string& id ) { const char* menu_ui; if( id == "popup_menu" ) menu_ui = popup_menu; - else if( id == "popup_menu" ) menu_ui = popup_menu; else if( id == "popup_menu_etc" ) menu_ui = popup_menu_etc; else if( id == "popup_menu_mul" ) menu_ui = popup_menu_mul; else if( id == "popup_menu_mul_etc" ) menu_ui = popup_menu_mul_etc;