You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okay, so i have looked into this and seems like it's not as easy as I though...
(Note that the following benchmarks are very unscientific and the random start scene might have a significant impact. I ran all of these a few times an the times looked relatively stable)
Baseline speed is around 47s for 50 Samples for me.
turning all #[inline] annotations into #[inline(always)] makes the code slightly slower at 48s
and removing all #[inline] annotations actually slows us down even more to 50s.
It looks like #[inline] also inlines across code-gen units. Since code optimized for speed is usually compiled with only
one codegen unit that shouldn't be relevant for us though:
After tuning the Cargo.toml a bit:
codegen-units = 1lto = true
the baseline stays the same at 47s, but the version without the #[inline] annotations goes down to 45s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.