Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 16.04, compile warning with JGRPP 0.28.0 #70

Closed
auge8472 opened this issue Nov 25, 2018 · 2 comments
Closed

Ubuntu 16.04, compile warning with JGRPP 0.28.0 #70

auge8472 opened this issue Nov 25, 2018 · 2 comments

Comments

@auge8472
Copy link
Contributor

@auge8472 auge8472 commented Nov 25, 2018

Fetched and compiled the new version of the patch pack and got a warning that I didn't saw before. I've no clue if it is in your patch pack or in OpenTTD in itself.

[SRC] Compiling script/squirrel.cpp
/home/auge/Projekte/OpenTTD-patches/Arbeitskopie/src/script/squirrel.cpp: In member function ‘SQRESULT Squirrel::LoadFile(HSQUIRRELVM, const char*, SQBool)’:
/home/auge/Projekte/OpenTTD-patches/Arbeitskopie/src/script/squirrel.cpp:452:36: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
   fread(&bom, 1, sizeof(bom), file); // Inside tar, no point checking return va
                                    ^
/home/auge/Projekte/OpenTTD-patches/Arbeitskopie/src/script/squirrel.cpp:490:35: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
    fread(&uc, 1, sizeof(uc), file);
                                   ^
@JGRennison

This comment has been minimized.

Copy link
Owner

@JGRennison JGRennison commented Nov 26, 2018

This looks to be caused by trunk commit OpenTTD/OpenTTD@6accbf9, which isn't specific to this patch pack.
The warning is not that important really, but you could report it upstream if you fancied.

@auge8472

This comment has been minimized.

Copy link
Contributor Author

@auge8472 auge8472 commented Nov 26, 2018

No, I can't see any influence to my gameplay. So it's only something I spotted.

Anyway, I'll report it. Thank you for your clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.