New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new constants #17

Merged

JJ merged 2 commits into JJ:master from Xliff:master

Oct 7, 2018

Contributor

Xliff commented Oct 7, 2018

Pull request template for `Math::Constants`

Adding new constants.

What kind of constants are you adding and its origin

Adds new constants for standard gravity(g), electron mass, proton mass and neutron mass. Sourced from Wikipedia:

g: https://en.wikipedia.org/wiki/Standard_gravity
electron-mass: https://en.wikipedia.org/wiki/Electron_rest_mass
proton-mass: https://en.wikipedia.org/wiki/Proton
neutron-mass: https://en.wikipedia.org/wiki/Neutron

Check list

[x ] It's a well known constant and I have added a reference for it
I have added a test and it works.
I'm using the usual naming and abbreviation conventions.

Xliff added 2 commits

October 7, 2018 03:18


          - Adds standard gravity, electron mass, neutron mass and proton mass.

57a998e

+ Tests in future commit.


          - Adds tests for afforementioned units.

032d899

JJ merged commit e10c2ad into JJ:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment