Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Change Proposal: Make a Polymorphic VI for Assert (Request for Comments) #26
Background / Problem Statement
Often, one wishes to change an existing call to a different kind of Assert -- e.g. Assert Equal to Assert Not Equal, or Assert Equal Value to Assert Equal Value and Type.
Proposed Solution / Poly VI
Also, we could remove all the instances of Assert from the palette and simply have a single Assert VI.
changed the title
Change Proposal: Make a Polymorphic VI for Assert (Please Discuss)
Oct 18, 2018
I really like this proposal.
I have changed my mind, I didn't think it though before well...
One the one hand, it is nice to have single, poly VI which allows to select any available assert.
Now we're done.
Although, with no-polymorphic VI, it could be done within 3 upper mentioned steps, without additional mouse clicks.
Maybe, there could be done compromise, and there could be left both approaches on the function pallete - poly VI; and separated VIs?
Thanks a lot! Looks nice.
P.S. Maybe, it worth to share information about these changes on NI forum (Unit Testing Group), to receive more feedbacks? Because I guess not all the users of Caraya framework check github...
FWIW, the Polymorphic VI's icon is just shown in the palette... once dropped on the block diagram, it takes the icon of whatever flavor you choose, so a different color would just highlight it.
Sharing on the different forums is a great idea. I propose that we let JKI and @jimkring review the latest code, and then we can publicize the next build as "Beta Release" to gather comments from the larger community before pushing it into "production".