From a6ca1cbb0900a9e83fed62831dc5167b80df43dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Fri, 17 May 2024 15:46:45 -0400 Subject: [PATCH] fix typings and simlify booleanify --- packages/babel-cli/src/babel/options.ts | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/packages/babel-cli/src/babel/options.ts b/packages/babel-cli/src/babel/options.ts index d5b1969ce952..1ca3c752e9e9 100644 --- a/packages/babel-cli/src/babel/options.ts +++ b/packages/babel-cli/src/babel/options.ts @@ -364,18 +364,15 @@ export default function parseArgv(args: Array): CmdOptions | null { }; } -function booleanify(val: "false" | 0 | ""): false; -function booleanify(val: "true" | 1): true; -function booleanify(val: any): any { - if (val === undefined) return undefined; - - // eslint-disable-next-line eqeqeq - if (val === "true" || val == 1) { +function booleanify(val: "false" | "0" | ""): false; +function booleanify(val: "true" | "1"): true; +function booleanify(val: string): boolean | string { + if (val === "true" || val === "1") { return true; } - // eslint-disable-next-line eqeqeq - if (val === "false" || val == 0 || !val) { + // false for --opt=false; 0 for --opt=0 or --opt 0; "" for --opt= + if (val === "false" || val === "0" || val === "") { return false; }