Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test files to .npmignore #3

Merged
merged 1 commit into from Nov 20, 2017

Conversation

@ai
Copy link
Contributor

commented Nov 19, 2017

A lot of people complain about node_modules size. So it will be good to take care and clean npm package from unnecessary test files.

@JLHwung You can check npm package content by calling npm pack command and open generated .tgz file.

@JLHwung

This comment has been minimized.

Copy link
Owner

commented Nov 20, 2017

Great work! I don't realize the yarn.lock can be added to npmignore until I go through https://yarnpkg.com/lang/en/docs/yarn-lock/#toc-check-into-source-control carefully.

@JLHwung JLHwung merged commit ff3b96a into JLHwung:master Nov 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.