Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint uppercase #4

Merged
merged 2 commits into from Nov 20, 2017

Conversation

@ai
Copy link
Contributor

commented Nov 19, 2017

According ESLint website, the team prefer to capitalize ES and L.

@JLHwung should we update the docs too?

Also thanks for the project. I am planning to use it in Autoprefixer and PostCSS.

README.md Outdated

It is a simple wrap for [eslint](https://github.com/eslint/eslint) and works well with eslint from 1.x to the latest version. It runs lint check only in first CI job so that we can speed up build time and reduce unnecessary computation burden for CI service.
It is a simple wrap for [ESLint](https://github.com/eslint/eslint) and works well with eslint ESLint 1.x to the latest version. It runs lint check only in first CI job so that we can speed up build time and reduce unnecessary computation burden for CI service.

This comment has been minimized.

Copy link
@JLHwung

JLHwung Nov 20, 2017

Owner

Should be with ESLint from 1.x

This comment has been minimized.

Copy link
@ai

ai Nov 20, 2017

Author Contributor

Oops, fixed

@JLHwung

This comment has been minimized.

Copy link
Owner

commented Nov 20, 2017

@ai Good catch for capitalization consistency! we should do %s/eslint/ESLint/g on any literals.

@JLHwung JLHwung merged commit e879745 into JLHwung:master Nov 20, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.