Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page 367: Typo in return value of operator!= #145

Closed
danzek opened this issue Jan 31, 2020 · 2 comments
Closed

Page 367: Typo in return value of operator!= #145

danzek opened this issue Jan 31, 2020 · 2 comments

Comments

@danzek
Copy link

danzek commented Jan 31, 2020

The top of p. 367 (print edition) indicates that both operator== and operator!= return true, but in Listing 11-18 the latter returns false.

@danzek
Copy link
Author

danzek commented Jan 31, 2020

Also, I’ve only been posting substantive typos, by which I mean that they could cause confusion (granted, both typos I’ve reported thus far have been minor). I’ve also identified:

  • simple grammatical typos (e.g., “that share some a common theme...” on p. 311),
  • simple formatting issues (e.g., no spaces between the typename, ellipsis (...), and the variable name in the parameter pack pattern/example in Listing 9-7 on p. 252), and
  • a potentially unfinished example (e.g., the comment indicating “TODO” on p. 207).

I haven’t bothered reporting these as they are all very minor (and for all I know, the last one in this list may have been intentional). Do you want me to stay on my current path (only reporting more substantive typos) or would you prefer I also report these very paltry typos as well (with the caveat that I’m not going to reread the past 370+ pages to find them again, so I’ll only report new ones going forward)?

I don’t want to waste your time, but if No Starch Press intends to print another edition with these fixed (or you find time to update the book for C++20 in the next few years :P), it takes me very little time to report them on my phone.

@JLospinoso
Copy link
Owner

JLospinoso commented Mar 8, 2020

Thanks, @danzek! I'll have a look at these others

kruschk pushed a commit to kruschk/ccc that referenced this issue Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants