Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page 261: Non-existant variable "l" (letter L) is used in code example. Should be "len" instead. #88

Closed
WraithGlade opened this issue Jan 2, 2020 · 2 comments

Comments

@WraithGlade
Copy link

@WraithGlade WraithGlade commented Jan 2, 2020

This error is present in both the larger example box (below "Listing 9-17 illustrates how to assign a generic lambda into a variable and then use the lambda in two different template instantiations.") and also in the smaller example box (just below "Without a generic lambda, you’d have to declare the parameter types explicitly, like the following:").

PS: The font you're using makes it very hard to distinguish between the number 1 and the letter L in lowercase. For future reference, a font that doesn't suffer from this problem is Deja Vu Sans Mono (see https://en.wikipedia.org/wiki/DejaVu_fonts#Sans_Mono).

This may have contributed to people not spotting the error until now. It looks too much like a valid number.

JLospinoso added a commit that referenced this issue Jan 9, 2020
@JLospinoso

This comment has been minimized.

Copy link
Owner

@JLospinoso JLospinoso commented Jan 9, 2020

Thanks, @WraithGlade!

@JLospinoso JLospinoso closed this Jan 9, 2020
@nicebub

This comment has been minimized.

Copy link

@nicebub nicebub commented Feb 9, 2020

On your website that explains this in the Errata, and what @WraithGlade did not specify is that this is on page 261 and on the top of page 262 where the "smaller" example can be found.

Also What you explain on your website only discusses listing 9-17 and the use of 'l' instead of 'len' in the use of the transform functions but you didn't explain that the same error was made inside the 'for loop' at the bottom of the listing as well.

The code example for 9-17 in the chapter9 folder has not been changed on your GitHub yet to reflect your awareness and fix of the error.
Thank you again for a great book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.