Updated TAMS Command Station code for JMRI - for test version #1566

Merged
merged 39 commits into from Jun 29, 2016

Conversation

Projects
None yet
4 participants
@janboen
Contributor

janboen commented Jun 23, 2016

Please find enclosed the release note of the Tams command station implementation on JMRI.
The MasterControl system is a basic, low cost solution from the German manufacturer Tams. It has very recently been discontinued after 10 years of production awaiting the launch of a new command station.
It supports DCC and MM protocols, allows turnout control and has an S88 interface to capture sensor information.
The current version of the Tams MasterControl command station implementation is an enhancement of the initial implementation done by Kevin Dickerson.
The changes have mainly been done to improve the efficiency of the polling system.
By switching from ASCII to binary commands for the polling the volume of poll replies is greatly reduced as the Tams MasterControl only sends status changes which did not originate from JMRI.
When using ASCII commands this is not the case.
Also the polling commands and replies are much more compact when using binary commands.

The following functionality is present:
1- Support for controlling and programming loco's
2- Defining and controlling turnouts connected via DCC
3- Defining and getting feedback from S88 connected sensors
4- Monitor Tams commands
5- Send Tams commands
6- Power Control
7- Read the Tams Loco database
8- Read Tams Command Station firmware version and serial number
9- Tams Simulator connection

Known limitations:
1- Only one Tams MasterControl can be connected
2- Programming
None
3- Throttles
Due to technical limitations in the old P50 protocol JMRI can only control and display 14 functions and it can only capture status changes coming from outside JMRI for f1 to f8.
After the first JMRI throttle changes all 14 functions will be displayed correctly again in case of discrepancy.
Speed, direction and light work as should.
An enhancement to the P50 protocol has been done so functions f15 to f24 can also be properly controlled but this is not yet implemented in this version.
4- Turnouts
None
5- Sensors
None
6- Power Control
None
7- Tams Command Monitor
The binary messages are not really human readable
8- Send Tams Commands
Only a limited set of command replies are interpreted by JMRI although all are correctly displayed in the Command Monitor
9- Tams Loco Database
No integration with JMRI
10- Tams Simulator
Does not yet reply properly to binary poll messages

janboen and others added some commits Jun 13, 2016

Updates to TamsTurnoutManager
- decoderTurnoutState should not be static (so can reference TurnoutManager state), should not be private (so tests can be written later)

- provide turnout from "this" manager, don't do lookup of the manager

- The change in state is from a CS, so use setCommandedStateFromCS
Initial implementation of tests
(Not yet known to compile due to missing file in branch)
Merge pull request #3 from bobjacobsen/test-update-to-HEAD-JMRI-JMRI-…
…master-for-Tams

Merge to current contents of JMRI/JMRI master branch
Bug fix
In TamsTrafficController so now all binary commands are properly
handled.
Updated TamsTrafficController with stub endOfMessage method
This doesn't work as the replies are not handled.
Support for all functions is working
Binary polling commands for power, turnouts and sensors
Loco is still using ASCII polling
Some fixes to be done in command monitor and simulator to be reworked.
Reworked TamsThrottle to binary polling
Must clean this up so only 1 polling message is generated and answers
properly ditributed to all open TamsThrottle.
@mattharris

This comment has been minimized.

Show comment
Hide comment
@mattharris

mattharris Jun 23, 2016

Member

@janboen All the .metadata/* files should be removed, as well as RemoteSystemsTempFiles/.project before this can be merged.

Member

mattharris commented Jun 23, 2016

@janboen All the .metadata/* files should be removed, as well as RemoteSystemsTempFiles/.project before this can be merged.

help/en/html/hardware/tams/index.shtml
@@ -72,7 +72,8 @@ The USB port works under Linux and Windows - both have been tested.
<a name="documentation"></a><h2>Documentation</h2>
<h3>Third Party info</h3>
-<p>The <a href="http://tams-online.de/MasterControl">TAMs.de manufacturer's website</a>
+<p>Web site and info mainly in German, user manuals also in English (and other languages) for download</p>
+<p>The <a href="http://tams-online.de/MasterControl">tams.de manufacturer's website</a></p>

This comment has been minimized.

@rhwood

rhwood Jun 23, 2016

Contributor

"tams.de" is an unrelated site. You should probably change "tams.de" to "Tams" since the firm is "Tams Electronic GmbH" unless TAMS is a product from Tams (either way the capitalization needs to be consistent).

@rhwood

rhwood Jun 23, 2016

Contributor

"tams.de" is an unrelated site. You should probably change "tams.de" to "Tams" since the firm is "Tams Electronic GmbH" unless TAMS is a product from Tams (either way the capitalization needs to be consistent).

@janboen

This comment has been minimized.

Show comment
Hide comment
@janboen

janboen Jun 23, 2016

Contributor

Hi Matthew,

OK. I'm new to this... First pull request.
How/where do I remove these files?
I just selected the "Tams" folder and committed.
I see no .metadata or |RemoteSystemsTempFiles/.project in Eclipse.|
|
|
|Thanks,|
|
|
|
|
|Jan
|

On 23/06/2016 21:29, Matthew Harris wrote:

@janboen https://github.com/janboen All the |.metadata| files should
be removed, as well as |RemoteSystemsTempFiles/.project| before this
can be merged.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1566 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/ABe0JXG5f0IN8dfZAak3oYmQsVff0c9Oks5qOt61gaJpZM4I9Jca.


Dit e-mailbericht is gecontroleerd op virussen met Avast antivirussoftware.
https://www.avast.com/antivirus

Contributor

janboen commented Jun 23, 2016

Hi Matthew,

OK. I'm new to this... First pull request.
How/where do I remove these files?
I just selected the "Tams" folder and committed.
I see no .metadata or |RemoteSystemsTempFiles/.project in Eclipse.|
|
|
|Thanks,|
|
|
|
|
|Jan
|

On 23/06/2016 21:29, Matthew Harris wrote:

@janboen https://github.com/janboen All the |.metadata| files should
be removed, as well as |RemoteSystemsTempFiles/.project| before this
can be merged.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1566 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/ABe0JXG5f0IN8dfZAak3oYmQsVff0c9Oks5qOt61gaJpZM4I9Jca.


Dit e-mailbericht is gecontroleerd op virussen met Avast antivirussoftware.
https://www.avast.com/antivirus

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 23, 2016

Member

How/where do I remove these files?

Anything you commit and push to your repository will be added to this PR until it’s merged. So to remove a file

git rm path/to/my/file.java
git commit
git push

will do it.

Bob

Member

bobjacobsen commented Jun 23, 2016

How/where do I remove these files?

Anything you commit and push to your repository will be added to this PR until it’s merged. So to remove a file

git rm path/to/my/file.java
git commit
git push

will do it.

Bob

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Jun 23, 2016

Contributor

I think Eclipse will regenerate those files every time, so you need to also add .metadata and RemoteSystemsTempFiles to .gitignore and commit that first.

You may prefer to use git rm --cached -r .metadata RemoteSystemsTempFile after committing the .gitignore file.

Contributor

rhwood commented Jun 23, 2016

I think Eclipse will regenerate those files every time, so you need to also add .metadata and RemoteSystemsTempFiles to .gitignore and commit that first.

You may prefer to use git rm --cached -r .metadata RemoteSystemsTempFile after committing the .gitignore file.

@bobjacobsen bobjacobsen added the WIP label Jun 23, 2016

@bobjacobsen bobjacobsen added this to the After 4.4 milestone Jun 23, 2016

janboen added some commits Jun 24, 2016

Update turnout state in JMRI problem
This version is as quiet as can be but the above problem has to be
fixed.
@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 25, 2016

Member

You can use log.debug instead of commenting out log.info. That is normally silent, but can easily be turn on via the default.lcf file when more output is desired.

Member

bobjacobsen commented on 4c4ea21 Jun 25, 2016

You can use log.debug instead of commenting out log.info. That is normally silent, but can easily be turn on via the default.lcf file when more output is desired.

This comment has been minimized.

Show comment
Hide comment
@janboen

janboen Jun 27, 2016

Contributor

Thanks!

Contributor

janboen replied Jun 27, 2016

Thanks!

janboen added some commits Jun 27, 2016

Tams package should now work properly
No more use of log.info but switched to log.debug and proper use of
default.lcf.
TamsTurnout problem resolved.
Please let me know how I can get rid of the unwanted files.
Update .gitignore
added .metadata and RemoteSystemTempFiles as per RHWood recommendations.
@janboen

This comment has been minimized.

Show comment
Hide comment
@janboen

janboen Jun 27, 2016

Contributor

Hi,

Updated .gitignore and done as suggested by Randall.
I all OK now?

Thanks,

Jan

Contributor

janboen commented Jun 27, 2016

Hi,

Updated .gitignore and done as suggested by Randall.
I all OK now?

Thanks,

Jan

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 27, 2016

Member

There are some file-content merge conflicts. I'll fix those and send you an update so we can get a clean merge.

Member

bobjacobsen commented Jun 27, 2016

There are some file-content merge conflicts. I'll fix those and send you an update so we can get a clean merge.

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 27, 2016

Member

If you could please merge PR janboen/JMRI#4, that should fix the conflict (including fixing it here). That should then automatically start the test builds.

Member

bobjacobsen commented Jun 27, 2016

If you could please merge PR janboen/JMRI#4, that should fix the conflict (including fixing it here). That should then automatically start the test builds.

@bobjacobsen bobjacobsen modified the milestones: 4.5.1, After 4.4 Jun 27, 2016

bobjacobsen and others added some commits Jun 27, 2016

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 28, 2016

Member

You still need to merge the PR that I added to your fork. The one you did fixed the merge conflict, thanks, but not the problem with the JUnit tests.

Member

bobjacobsen commented Jun 28, 2016

You still need to merge the PR that I added to your fork. The one you did fixed the merge conflict, thanks, but not the problem with the JUnit tests.

@janboen

This comment has been minimized.

Show comment
Hide comment
@janboen

janboen Jun 28, 2016

Contributor

Not sure what to do now...
C:\Users\Jan\git\JMRI2 [master ↕ +4 ~3 -0 !]> git push origin master
To https://github.com/janboen/JMRI
! [rejected] master -> master (non-fast-forward)
error: failed to push some refs to 'https://github.com/janboen/JMRI'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
C:\Users\Jan\git\JMRI2 [master ↕ +4 ~3 -0 !]> git pull origin master
From https://github.com/janboen/JMRI

  • branch master -> FETCH_HEAD
    Auto-merging java/src/jmri/jmrix/tams/TamsTrafficController.java
    CONFLICT (content): Merge conflict in java/src/jmri/jmrix/tams/TamsTrafficController.java
Contributor

janboen commented Jun 28, 2016

Not sure what to do now...
C:\Users\Jan\git\JMRI2 [master ↕ +4 ~3 -0 !]> git push origin master
To https://github.com/janboen/JMRI
! [rejected] master -> master (non-fast-forward)
error: failed to push some refs to 'https://github.com/janboen/JMRI'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
C:\Users\Jan\git\JMRI2 [master ↕ +4 ~3 -0 !]> git pull origin master
From https://github.com/janboen/JMRI

  • branch master -> FETCH_HEAD
    Auto-merging java/src/jmri/jmrix/tams/TamsTrafficController.java
    CONFLICT (content): Merge conflict in java/src/jmri/jmrix/tams/TamsTrafficController.java
@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 28, 2016

Member
  1. Click merge on janboen/JMRI#4

That might be enough. If this is ready to merge after that (it'll pass tests; do you have anything else you want to change?), we can merge it here and you'll be able to pick it up into the repository on your computer to complete the loop.

If this isn't ready yet, then:

  1. On your computer, do:
git pull https://github.com/janboen/JMRI.git master
git push
Member

bobjacobsen commented Jun 28, 2016

  1. Click merge on janboen/JMRI#4

That might be enough. If this is ready to merge after that (it'll pass tests; do you have anything else you want to change?), we can merge it here and you'll be able to pick it up into the repository on your computer to complete the loop.

If this isn't ready yet, then:

  1. On your computer, do:
git pull https://github.com/janboen/JMRI.git master
git push
@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 28, 2016

Member

Oh, rats. janboen/JMRI#4 is showing conflicts, probably because of something that was in your PR5. That wasn't such a good idea.

Step 2 above (should) still work to get the current contents of your GitHub repository back onto your own computer. You can sort it out there so that you can push anything back to your GitHub repository. Once that's done, you'll need to apply those fixes I made for you.

What will probably work is (after you're back to being able to git push) is

git pull https://github.com/bobjacobsen/JMRI.git master
(fix the conflicts you created and do git add / git commit to store them)
git push
Member

bobjacobsen commented Jun 28, 2016

Oh, rats. janboen/JMRI#4 is showing conflicts, probably because of something that was in your PR5. That wasn't such a good idea.

Step 2 above (should) still work to get the current contents of your GitHub repository back onto your own computer. You can sort it out there so that you can push anything back to your GitHub repository. Once that's done, you'll need to apply those fixes I made for you.

What will probably work is (after you're back to being able to git push) is

git pull https://github.com/bobjacobsen/JMRI.git master
(fix the conflicts you created and do git add / git commit to store them)
git push
@janboen

This comment has been minimized.

Show comment
Hide comment
@janboen

janboen Jun 28, 2016

Contributor

Is it OK now?
In my Eclipse TamsTrafficController has disappeared.
This is what git shows me
C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git pull https://github.com/bobjacobsen/JMRI.git master
From https://github.com/bobjacobsen/JMRI

  • branch master -> FETCH_HEAD
    Already up-to-date.
    C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git push
    Counting objects: 45, done.
    Delta compression using up to 8 threads.
    Compressing objects: 100% (45/45), done.
    Writing objects: 100% (45/45), 3.85 KiB | 0 bytes/s, done.
    Total 45 (delta 37), reused 0 (delta 0)
    To https://github.com/janboen/JMRI
    b148ec4..0f61b6e master -> master
    C:\Users\Jan\git\JMRI2 [master ≡ +0 ~2 -0 !]>
Contributor

janboen commented Jun 28, 2016

Is it OK now?
In my Eclipse TamsTrafficController has disappeared.
This is what git shows me
C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git pull https://github.com/bobjacobsen/JMRI.git master
From https://github.com/bobjacobsen/JMRI

  • branch master -> FETCH_HEAD
    Already up-to-date.
    C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git push
    Counting objects: 45, done.
    Delta compression using up to 8 threads.
    Compressing objects: 100% (45/45), done.
    Writing objects: 100% (45/45), 3.85 KiB | 0 bytes/s, done.
    Total 45 (delta 37), reused 0 (delta 0)
    To https://github.com/janboen/JMRI
    b148ec4..0f61b6e master -> master
    C:\Users\Jan\git\JMRI2 [master ≡ +0 ~2 -0 !]>
@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 28, 2016

Member

No, it's not OK.

Please don't touch anything. I will try to recover this.

On Jun 28, 2016, at 9:38 AM, Jan Boen notifications@github.com wrote:

Is it OK now?
In my Eclipse TamsTrafficController has disappeared.
This is what git shows me
C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git pull https://github.com/bobjacobsen/JMRI.git master
From https://github.com/bobjacobsen/JMRI

branch master -> FETCH_HEAD Already up-to-date. C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git push Counting objects: 45, done. Delta compression using up to 8 threads. Compressing objects: 100% (45/45), done. Writing objects: 100% (45/45), 3.85 KiB | 0 bytes/s, done. Total 45 (delta 37), reused 0 (delta 0) To https://github.com/janboen/JMRI b148ec4..0f61b6e master -> master C:\Users\Jan\git\JMRI2 [master ≡ +0 ~2 -0 !]>

You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Member

bobjacobsen commented Jun 28, 2016

No, it's not OK.

Please don't touch anything. I will try to recover this.

On Jun 28, 2016, at 9:38 AM, Jan Boen notifications@github.com wrote:

Is it OK now?
In my Eclipse TamsTrafficController has disappeared.
This is what git shows me
C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git pull https://github.com/bobjacobsen/JMRI.git master
From https://github.com/bobjacobsen/JMRI

branch master -> FETCH_HEAD Already up-to-date. C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git push Counting objects: 45, done. Delta compression using up to 8 threads. Compressing objects: 100% (45/45), done. Writing objects: 100% (45/45), 3.85 KiB | 0 bytes/s, done. Total 45 (delta 37), reused 0 (delta 0) To https://github.com/janboen/JMRI b148ec4..0f61b6e master -> master C:\Users\Jan\git\JMRI2 [master ≡ +0 ~2 -0 !]>

You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@janboen

This comment has been minimized.

Show comment
Hide comment
@janboen

janboen Jun 28, 2016

Contributor

Hi Bob,

Ok. I'll not touch anything until further notice.
Let me know if you want to get the latest TamsTrafficController (or any
other part or whole Tams code).
I have sources etc in a very recent jar file if needed.

Sorry for the mess I created...

Jan

On 28/06/2016 22:09, Bob Jacobsen wrote:

No, it's not OK.

Please don't touch anything. I will try to recover this.

On Jun 28, 2016, at 9:38 AM, Jan Boen notifications@github.com wrote:

Is it OK now?
In my Eclipse TamsTrafficController has disappeared.
This is what git shows me
C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git pull
https://github.com/bobjacobsen/JMRI.git master
From https://github.com/bobjacobsen/JMRI

branch master -> FETCH_HEAD Already up-to-date.
C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git push Counting
objects: 45, done. Delta compression using up to 8 threads.
Compressing objects: 100% (45/45), done. Writing objects: 100%
(45/45), 3.85 KiB | 0 bytes/s, done. Total 45 (delta 37), reused 0
(delta 0) To https://github.com/janboen/JMRI b148ec4..0f61b6e master
-> master C:\Users\Jan\git\JMRI2 [master ≡ +0 ~2 -0 !]>

You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1566 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/ABe0JT9KKRlmJU_uVZLAua_j_o0b2YEiks5qQX9vgaJpZM4I9Jca.


Dit e-mailbericht is gecontroleerd op virussen met Avast antivirussoftware.
https://www.avast.com/antivirus

Contributor

janboen commented Jun 28, 2016

Hi Bob,

Ok. I'll not touch anything until further notice.
Let me know if you want to get the latest TamsTrafficController (or any
other part or whole Tams code).
I have sources etc in a very recent jar file if needed.

Sorry for the mess I created...

Jan

On 28/06/2016 22:09, Bob Jacobsen wrote:

No, it's not OK.

Please don't touch anything. I will try to recover this.

On Jun 28, 2016, at 9:38 AM, Jan Boen notifications@github.com wrote:

Is it OK now?
In my Eclipse TamsTrafficController has disappeared.
This is what git shows me
C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git pull
https://github.com/bobjacobsen/JMRI.git master
From https://github.com/bobjacobsen/JMRI

branch master -> FETCH_HEAD Already up-to-date.
C:\Users\Jan\git\JMRI2 [master ↑ +0 ~2 -0 !]> git push Counting
objects: 45, done. Delta compression using up to 8 threads.
Compressing objects: 100% (45/45), done. Writing objects: 100%
(45/45), 3.85 KiB | 0 bytes/s, done. Total 45 (delta 37), reused 0
(delta 0) To https://github.com/janboen/JMRI b148ec4..0f61b6e master
-> master C:\Users\Jan\git\JMRI2 [master ≡ +0 ~2 -0 !]>

You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1566 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/ABe0JT9KKRlmJU_uVZLAua_j_o0b2YEiks5qQX9vgaJpZM4I9Jca.


Dit e-mailbericht is gecontroleerd op virussen met Avast antivirussoftware.
https://www.avast.com/antivirus

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 28, 2016

Member

Ok. I'll not touch anything until further notice.
Let me know if you want to get the latest TamsTrafficController (or any
other part or whole Tams code).
I have sources etc in a very recent jar file if needed.

Sorry for the mess I created…

Is OK. Frustrating, but OK.

I can’t accept you sending a copy of the text of a Java file, incidentally. The whole point of source-control systems like Git is to avoid doing that, because that way changes get lost.

So I’m pulling your entire commit history and trying to disentagle it. Once that’s done, we can figure out which commits caused the problem, and drop those.

Bob

Member

bobjacobsen commented Jun 28, 2016

Ok. I'll not touch anything until further notice.
Let me know if you want to get the latest TamsTrafficController (or any
other part or whole Tams code).
I have sources etc in a very recent jar file if needed.

Sorry for the mess I created…

Is OK. Frustrating, but OK.

I can’t accept you sending a copy of the text of a Java file, incidentally. The whole point of source-control systems like Git is to avoid doing that, because that way changes get lost.

So I’m pulling your entire commit history and trying to disentagle it. Once that’s done, we can figure out which commits caused the problem, and drop those.

Bob

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Jun 29, 2016

Member

PR #1592 is a replacement for this. It's made from a merge of this branch (at one commit from end, to avoid an improperly-deleted file) with JMRI/JMRI master and some corrections. Once that is merged, this should be closed.

Member

bobjacobsen commented Jun 29, 2016

PR #1592 is a replacement for this. It's made from a merge of this branch (at one commit from end, to avoid an improperly-deleted file) with JMRI/JMRI master and some corrections. Once that is merged, this should be closed.

@bobjacobsen bobjacobsen merged commit 0f61b6e into JMRI:master Jun 29, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@rhwood rhwood removed the WIP label Jul 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment