Fix logic error in JRE detection on OS X #1801

Merged
merged 3 commits into from Aug 17, 2016

Conversation

Projects
None yet
4 participants
@rhwood
Contributor

rhwood commented Aug 16, 2016

Unlike the error in 4.5.1, this error correctly detected the right version of java, but acted as if it did not. This change causes us not to unset JAVA_HOME after confirming that JAVA_HOME has the right version of java.
Also remove redundant check that JAVA_HOME/bin/java is executable.

Fix logic error in JRE detection on OS X
Unlike the error in 4.5.1, this error correctly detected the right version of java, but acted as if it did not. This change causes us not to unset JAVA_HOME after confirming that JAVA_HOME has the right version of java.
Also remove redundant check that JAVA_HOME/bin/java is executable.
@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Aug 16, 2016

Member

Want a quick 4.5.3?

Member

bobjacobsen commented Aug 16, 2016

Want a quick 4.5.3?

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Aug 16, 2016

Contributor

@dheap Can you confirm this works on your computer without a JDK?

@bobjacobsen Could we apply this to the 4.5.2 branch and issue a new 4.5.2 for OS X users?

Contributor

rhwood commented Aug 16, 2016

@dheap Can you confirm this works on your computer without a JDK?

@bobjacobsen Could we apply this to the 4.5.2 branch and issue a new 4.5.2 for OS X users?

@pabender

This comment has been minimized.

Show comment
Hide comment
@pabender

pabender Aug 16, 2016

Member

On 08/16/2016 10:10 AM, Randall Wood wrote:

@bobjacobsen https://github.com/bobjacobsen Could we apply this to
the 4.5.2 branch and issue a new 4.5.2 for OS X users?

I think it would be better to release this as 4.5.3. It's easier to
make the announcement that this is available that way.

Paul

Member

pabender commented Aug 16, 2016

On 08/16/2016 10:10 AM, Randall Wood wrote:

@bobjacobsen https://github.com/bobjacobsen Could we apply this to
the 4.5.2 branch and issue a new 4.5.2 for OS X users?

I think it would be better to release this as 4.5.3. It's easier to
make the announcement that this is available that way.

Paul

@rhwood rhwood added this to the 4.5.3 milestone Aug 16, 2016

@rhwood rhwood added the Bug label Aug 16, 2016

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Aug 16, 2016

Member

Because our releases are labeled git tags, I'd rather not reuse numbers.

Happy to build a 4.5.3 either from HEAD or 4.5.2+this.

Member

bobjacobsen commented Aug 16, 2016

Because our releases are labeled git tags, I'd rather not reuse numbers.

Happy to build a 4.5.3 either from HEAD or 4.5.2+this.

@dheap

This comment has been minimized.

Show comment
Hide comment
@dheap

dheap Aug 16, 2016

Contributor

@rhwood Will do as soon as I get up this morning.

@dheap Can you confirm this works on your computer without a JDK?

@bobjacobsen Could we apply this to the 4.5.2 branch and issue a new 4.5.2 for OS X users?

Contributor

dheap commented Aug 16, 2016

@rhwood Will do as soon as I get up this morning.

@dheap Can you confirm this works on your computer without a JDK?

@bobjacobsen Could we apply this to the 4.5.2 branch and issue a new 4.5.2 for OS X users?

@dheap

This comment has been minimized.

Show comment
Hide comment
@dheap

dheap Aug 16, 2016

Contributor
Contributor

dheap commented Aug 16, 2016

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Aug 16, 2016

Contributor

@dheap If that's case somewhere $JAVACMD is being quoted incorrectly, since you verified the logic is at least correct.

Contributor

rhwood commented Aug 16, 2016

@dheap If that's case somewhere $JAVACMD is being quoted incorrectly, since you verified the logic is at least correct.

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Aug 16, 2016

Contributor

@dheap On the computer without the JDK, please run DecoderPro or PanelPro by opening Terminal.app and running the JMRI script instead of the launcher (instead of open /Applications/JMRI/DecoderPro.app run /Applications/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI and send us the output.

(I'm unable to create a VM with OS X to test all this for about a week.)

Contributor

rhwood commented Aug 16, 2016

@dheap On the computer without the JDK, please run DecoderPro or PanelPro by opening Terminal.app and running the JMRI script instead of the launcher (instead of open /Applications/JMRI/DecoderPro.app run /Applications/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI and send us the output.

(I'm unable to create a VM with OS X to test all this for about a week.)

@dheap

This comment has been minimized.

Show comment
Hide comment
@dheap

dheap Aug 16, 2016

Contributor

@rhwood Sounds feasible. I need to go out to the shed and finish repairs on club layout and finish packing into trailer, then pack tools, trains, clothes etc. to leave tomorrow morning.

I haven't got time to run with this in full, but will check back regularly and test anything as required.

Does this help:
Last login: Wed Aug 17 07:41:00 on console
New-England-Model-Railway-Club-Inc:~ NEMRC$ /Volumes/JMRI\ 4.5.3ish-201608162216-heap-R5a8094f/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI
expr: syntax error
/Volumes/JMRI 4.5.3ish-201608162216-heap-R5a8094f/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI: line 127: [: -le: unary operator expected
PWD: '/Volumes/JMRI 4.5.3ish-201608162216-heap-R5a8094f/JMRI'
CLASSPATH: '.:classes:java/classes:jmri.jar:lib/RXTXcomm.jar:lib/Serialio.jar:lib/WinRegistry-4.4.jar:lib/beansbinding-1.2.1.jar:lib/bluecove-2.1.1-SNAPSHOT.jar:lib/bluecove-bluez-2.1.1-SNAPSHOT.jar:lib/bluecove-gpl-2.1.1-SNAPSHOT.jar:lib/ch.ntb.usb.jar:lib/commons-io-1.3.1.jar:lib/commons-lang3-3.2.1.jar:lib/gluegen-rt.jar:lib/jackson-annotations-2.0.6.jar:lib/jackson-core-2.0.6.jar:lib/jackson-databind-2.0.6.jar:lib/jakarta-regexp-1.5.jar:lib/javacsv.jar:lib/javax.servlet-api-3.1.0.jar:lib/jdom-2.0.5.jar:lib/jdom.jar:lib/jetty-http-9.3.9.v20160517.jar:lib/jetty-io-9.3.9.v20160517.jar:lib/jetty-security-9.3.9.v20160517.jar:lib/jetty-server-9.3.9.v20160517.jar:lib/jetty-servlet-9.3.9.v20160517.jar:lib/jetty-util-9.3.9.v20160517.jar:lib/jhall.jar:lib/jhidrawplugin.jar:lib/jinput.jar:lib/jlfgr-1_0.jar:lib/jmdns.jar:lib/joal.jar:lib/jul-to-slf4j-1.7.13.jar:lib/jython.jar:lib/log4j-1.2.17.jar:lib/mailapi.jar:lib/openlcb.jar:lib/pi4j-core.jar:lib/pi4j-device.jar:lib/pi4j-gpio-extension.jar:lib/pi4j-service.jar:lib/slf4j-api-1.7.13.jar:lib/slf4j-log4j12-1.7.13.jar:lib/smtp.jar:lib/vecmath-1.5.2.jar:lib/websocket-api-9.3.9.v20160517.jar:lib/websocket-client-9.3.9.v20160517.jar:lib/websocket-common-9.3.9.v20160517.jar:lib/websocket-server-9.3.9.v20160517.jar:lib/websocket-servlet-9.3.9.v20160517.jar:lib/xAPlib.jar:lib/xbee-api-0.9.jar:lib/xercesImpl.jar'
Java CMD: '/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java'
APPNAME: 'DecoderPro'
OPTIONS: ' -noverify -Djava.security.policy=lib/security.policy -Djava.rmi.server.codebase=file:java/classes/ -Djava.library.path=.:lib/macosx:lib -Dapple.laf.useScreenMenuBar=true -Dcom.apple.macos.useScreenMenuBar=true -Dfile.encoding=UTF-8 -Xms96m -Xmxm -Dgnu.io.rxtx.NoVersionOutput=true'
DOCK_OPTIONS: '-Xdock:name=DecoderPro -Xdock:icon=/Volumes/JMRI 4.5.3ish-201608162216-heap-R5a8094f/JMRI/DecoderPro.app/Contents/Resources/DecoderPro.icns'
Invalid maximum heap size: -Xmxm
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Exit Status: 1
New-England-Model-Railway-Club-Inc:~ NEMRC$

@rhwood

@dheap If that's case somewhere $JAVACMD is being quoted incorrectly, since you verified the logic is at least correct

Contributor

dheap commented Aug 16, 2016

@rhwood Sounds feasible. I need to go out to the shed and finish repairs on club layout and finish packing into trailer, then pack tools, trains, clothes etc. to leave tomorrow morning.

I haven't got time to run with this in full, but will check back regularly and test anything as required.

Does this help:
Last login: Wed Aug 17 07:41:00 on console
New-England-Model-Railway-Club-Inc:~ NEMRC$ /Volumes/JMRI\ 4.5.3ish-201608162216-heap-R5a8094f/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI
expr: syntax error
/Volumes/JMRI 4.5.3ish-201608162216-heap-R5a8094f/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI: line 127: [: -le: unary operator expected
PWD: '/Volumes/JMRI 4.5.3ish-201608162216-heap-R5a8094f/JMRI'
CLASSPATH: '.:classes:java/classes:jmri.jar:lib/RXTXcomm.jar:lib/Serialio.jar:lib/WinRegistry-4.4.jar:lib/beansbinding-1.2.1.jar:lib/bluecove-2.1.1-SNAPSHOT.jar:lib/bluecove-bluez-2.1.1-SNAPSHOT.jar:lib/bluecove-gpl-2.1.1-SNAPSHOT.jar:lib/ch.ntb.usb.jar:lib/commons-io-1.3.1.jar:lib/commons-lang3-3.2.1.jar:lib/gluegen-rt.jar:lib/jackson-annotations-2.0.6.jar:lib/jackson-core-2.0.6.jar:lib/jackson-databind-2.0.6.jar:lib/jakarta-regexp-1.5.jar:lib/javacsv.jar:lib/javax.servlet-api-3.1.0.jar:lib/jdom-2.0.5.jar:lib/jdom.jar:lib/jetty-http-9.3.9.v20160517.jar:lib/jetty-io-9.3.9.v20160517.jar:lib/jetty-security-9.3.9.v20160517.jar:lib/jetty-server-9.3.9.v20160517.jar:lib/jetty-servlet-9.3.9.v20160517.jar:lib/jetty-util-9.3.9.v20160517.jar:lib/jhall.jar:lib/jhidrawplugin.jar:lib/jinput.jar:lib/jlfgr-1_0.jar:lib/jmdns.jar:lib/joal.jar:lib/jul-to-slf4j-1.7.13.jar:lib/jython.jar:lib/log4j-1.2.17.jar:lib/mailapi.jar:lib/openlcb.jar:lib/pi4j-core.jar:lib/pi4j-device.jar:lib/pi4j-gpio-extension.jar:lib/pi4j-service.jar:lib/slf4j-api-1.7.13.jar:lib/slf4j-log4j12-1.7.13.jar:lib/smtp.jar:lib/vecmath-1.5.2.jar:lib/websocket-api-9.3.9.v20160517.jar:lib/websocket-client-9.3.9.v20160517.jar:lib/websocket-common-9.3.9.v20160517.jar:lib/websocket-server-9.3.9.v20160517.jar:lib/websocket-servlet-9.3.9.v20160517.jar:lib/xAPlib.jar:lib/xbee-api-0.9.jar:lib/xercesImpl.jar'
Java CMD: '/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java'
APPNAME: 'DecoderPro'
OPTIONS: ' -noverify -Djava.security.policy=lib/security.policy -Djava.rmi.server.codebase=file:java/classes/ -Djava.library.path=.:lib/macosx:lib -Dapple.laf.useScreenMenuBar=true -Dcom.apple.macos.useScreenMenuBar=true -Dfile.encoding=UTF-8 -Xms96m -Xmxm -Dgnu.io.rxtx.NoVersionOutput=true'
DOCK_OPTIONS: '-Xdock:name=DecoderPro -Xdock:icon=/Volumes/JMRI 4.5.3ish-201608162216-heap-R5a8094f/JMRI/DecoderPro.app/Contents/Resources/DecoderPro.icns'
Invalid maximum heap size: -Xmxm
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Exit Status: 1
New-England-Model-Railway-Club-Inc:~ NEMRC$

@rhwood

@dheap If that's case somewhere $JAVACMD is being quoted incorrectly, since you verified the logic is at least correct

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Aug 16, 2016

Contributor

Found another raw use of java in the script.

@dheap Can you test the changes to line 123 as well?

Contributor

rhwood commented Aug 16, 2016

Found another raw use of java in the script.

@dheap Can you test the changes to line 123 as well?

@dheap

This comment has been minimized.

Show comment
Hide comment
@dheap

dheap Aug 16, 2016

Contributor

This crossed in the post with my last post. Had already done.

Contributor

dheap commented Aug 16, 2016

This crossed in the post with my last post. Had already done.

@dheap

This comment has been minimized.

Show comment
Hide comment
@dheap

dheap Aug 16, 2016

Contributor

Still an issue:

New-England-Model-Railway-Club-Inc:~ NEMRC$ /Volumes/JMRI\ 4.5.3ish-201608162328-heap-R1f5a915/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI
/Volumes/JMRI 4.5.3ish-201608162328-heap-R1f5a915/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI: line 123: JAVACMD: unbound variable
expr: syntax error
/Volumes/JMRI 4.5.3ish-201608162328-heap-R1f5a915/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI: line 127: [: -le: unary operator expected
PWD: '/Volumes/JMRI 4.5.3ish-201608162328-heap-R1f5a915/JMRI'
CLASSPATH: '.:classes:java/classes:jmri.jar:lib/RXTXcomm.jar:lib/Serialio.jar:lib/WinRegistry-4.4.jar:lib/beansbinding-1.2.1.jar:lib/bluecove-2.1.1-SNAPSHOT.jar:lib/bluecove-bluez-2.1.1-SNAPSHOT.jar:lib/bluecove-gpl-2.1.1-SNAPSHOT.jar:lib/ch.ntb.usb.jar:lib/commons-io-1.3.1.jar:lib/commons-lang3-3.2.1.jar:lib/gluegen-rt.jar:lib/jackson-annotations-2.0.6.jar:lib/jackson-core-2.0.6.jar:lib/jackson-databind-2.0.6.jar:lib/jakarta-regexp-1.5.jar:lib/javacsv.jar:lib/javax.servlet-api-3.1.0.jar:lib/jdom-2.0.5.jar:lib/jdom.jar:lib/jetty-http-9.3.9.v20160517.jar:lib/jetty-io-9.3.9.v20160517.jar:lib/jetty-security-9.3.9.v20160517.jar:lib/jetty-server-9.3.9.v20160517.jar:lib/jetty-servlet-9.3.9.v20160517.jar:lib/jetty-util-9.3.9.v20160517.jar:lib/jhall.jar:lib/jhidrawplugin.jar:lib/jinput.jar:lib/jlfgr-1_0.jar:lib/jmdns.jar:lib/joal.jar:lib/jul-to-slf4j-1.7.13.jar:lib/jython.jar:lib/log4j-1.2.17.jar:lib/mailapi.jar:lib/openlcb.jar:lib/pi4j-core.jar:lib/pi4j-device.jar:lib/pi4j-gpio-extension.jar:lib/pi4j-service.jar:lib/slf4j-api-1.7.13.jar:lib/slf4j-log4j12-1.7.13.jar:lib/smtp.jar:lib/vecmath-1.5.2.jar:lib/websocket-api-9.3.9.v20160517.jar:lib/websocket-client-9.3.9.v20160517.jar:lib/websocket-common-9.3.9.v20160517.jar:lib/websocket-server-9.3.9.v20160517.jar:lib/websocket-servlet-9.3.9.v20160517.jar:lib/xAPlib.jar:lib/xbee-api-0.9.jar:lib/xercesImpl.jar'
Java CMD: '/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java'
APPNAME: 'DecoderPro'
OPTIONS: ' -noverify -Djava.security.policy=lib/security.policy -Djava.rmi.server.codebase=file:java/classes/ -Djava.library.path=.:lib/macosx:lib -Dapple.laf.useScreenMenuBar=true -Dcom.apple.macos.useScreenMenuBar=true -Dfile.encoding=UTF-8 -Xms96m -Xmxm -Dgnu.io.rxtx.NoVersionOutput=true'
DOCK_OPTIONS: '-Xdock:name=DecoderPro -Xdock:icon=/Volumes/JMRI 4.5.3ish-201608162328-heap-R1f5a915/JMRI/DecoderPro.app/Contents/Resources/DecoderPro.icns'
Invalid maximum heap size: -Xmxm
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Exit Status: 1
New-England-Model-Railway-Club-Inc:~ NEMRC$

Contributor

dheap commented Aug 16, 2016

Still an issue:

New-England-Model-Railway-Club-Inc:~ NEMRC$ /Volumes/JMRI\ 4.5.3ish-201608162328-heap-R1f5a915/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI
/Volumes/JMRI 4.5.3ish-201608162328-heap-R1f5a915/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI: line 123: JAVACMD: unbound variable
expr: syntax error
/Volumes/JMRI 4.5.3ish-201608162328-heap-R1f5a915/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI: line 127: [: -le: unary operator expected
PWD: '/Volumes/JMRI 4.5.3ish-201608162328-heap-R1f5a915/JMRI'
CLASSPATH: '.:classes:java/classes:jmri.jar:lib/RXTXcomm.jar:lib/Serialio.jar:lib/WinRegistry-4.4.jar:lib/beansbinding-1.2.1.jar:lib/bluecove-2.1.1-SNAPSHOT.jar:lib/bluecove-bluez-2.1.1-SNAPSHOT.jar:lib/bluecove-gpl-2.1.1-SNAPSHOT.jar:lib/ch.ntb.usb.jar:lib/commons-io-1.3.1.jar:lib/commons-lang3-3.2.1.jar:lib/gluegen-rt.jar:lib/jackson-annotations-2.0.6.jar:lib/jackson-core-2.0.6.jar:lib/jackson-databind-2.0.6.jar:lib/jakarta-regexp-1.5.jar:lib/javacsv.jar:lib/javax.servlet-api-3.1.0.jar:lib/jdom-2.0.5.jar:lib/jdom.jar:lib/jetty-http-9.3.9.v20160517.jar:lib/jetty-io-9.3.9.v20160517.jar:lib/jetty-security-9.3.9.v20160517.jar:lib/jetty-server-9.3.9.v20160517.jar:lib/jetty-servlet-9.3.9.v20160517.jar:lib/jetty-util-9.3.9.v20160517.jar:lib/jhall.jar:lib/jhidrawplugin.jar:lib/jinput.jar:lib/jlfgr-1_0.jar:lib/jmdns.jar:lib/joal.jar:lib/jul-to-slf4j-1.7.13.jar:lib/jython.jar:lib/log4j-1.2.17.jar:lib/mailapi.jar:lib/openlcb.jar:lib/pi4j-core.jar:lib/pi4j-device.jar:lib/pi4j-gpio-extension.jar:lib/pi4j-service.jar:lib/slf4j-api-1.7.13.jar:lib/slf4j-log4j12-1.7.13.jar:lib/smtp.jar:lib/vecmath-1.5.2.jar:lib/websocket-api-9.3.9.v20160517.jar:lib/websocket-client-9.3.9.v20160517.jar:lib/websocket-common-9.3.9.v20160517.jar:lib/websocket-server-9.3.9.v20160517.jar:lib/websocket-servlet-9.3.9.v20160517.jar:lib/xAPlib.jar:lib/xbee-api-0.9.jar:lib/xercesImpl.jar'
Java CMD: '/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java'
APPNAME: 'DecoderPro'
OPTIONS: ' -noverify -Djava.security.policy=lib/security.policy -Djava.rmi.server.codebase=file:java/classes/ -Djava.library.path=.:lib/macosx:lib -Dapple.laf.useScreenMenuBar=true -Dcom.apple.macos.useScreenMenuBar=true -Dfile.encoding=UTF-8 -Xms96m -Xmxm -Dgnu.io.rxtx.NoVersionOutput=true'
DOCK_OPTIONS: '-Xdock:name=DecoderPro -Xdock:icon=/Volumes/JMRI 4.5.3ish-201608162328-heap-R1f5a915/JMRI/DecoderPro.app/Contents/Resources/DecoderPro.icns'
Invalid maximum heap size: -Xmxm
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Exit Status: 1
New-England-Model-Railway-Club-Inc:~ NEMRC$

@dheap

This comment has been minimized.

Show comment
Hide comment
@dheap

dheap Aug 17, 2016

Contributor
Contributor

dheap commented Aug 17, 2016

Move memory calculations
Move memory calculations to ensure they are done after we determine which java to use.
@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Aug 17, 2016

Contributor

Fixes should be in the PR now. I moved the calls to determine memory requirements to be later than the determine of which Java to use. Can you test this one last time?

On Aug 16, 2016, at 8:26 PM, Dave Heap notifications@github.com wrote:

JAVACMD is being used at line 123, but isn't being declared until line 285.

I don't have time to fix the logic now, but unfortunately I'll have to blow my test environment away in about 10 hours time by installing the JDK as the laptop needs to go on the road with the layout tomorrow morning.

Contributor

rhwood commented Aug 17, 2016

Fixes should be in the PR now. I moved the calls to determine memory requirements to be later than the determine of which Java to use. Can you test this one last time?

On Aug 16, 2016, at 8:26 PM, Dave Heap notifications@github.com wrote:

JAVACMD is being used at line 123, but isn't being declared until line 285.

I don't have time to fix the logic now, but unfortunately I'll have to blow my test environment away in about 10 hours time by installing the JDK as the laptop needs to go on the road with the layout tomorrow morning.

@dheap

This comment has been minimized.

Show comment
Hide comment
@dheap

dheap Aug 17, 2016

Contributor

All good now. Thanks for chasing this up. Now back to saw bench and drill press...

New-England-Model-Railway-Club-Inc:~ NEMRC$ /Volumes/JMRI\ 4.5.3ish-201608170220-heap-R10da6d0/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI
PWD: '/Volumes/JMRI 4.5.3ish-201608170220-heap-R10da6d0/JMRI'
CLASSPATH: '.:classes:java/classes:jmri.jar:lib/RXTXcomm.jar:lib/Serialio.jar:lib/WinRegistry-4.4.jar:lib/beansbinding-1.2.1.jar:lib/bluecove-2.1.1-SNAPSHOT.jar:lib/bluecove-bluez-2.1.1-SNAPSHOT.jar:lib/bluecove-gpl-2.1.1-SNAPSHOT.jar:lib/ch.ntb.usb.jar:lib/commons-io-1.3.1.jar:lib/commons-lang3-3.2.1.jar:lib/gluegen-rt.jar:lib/jackson-annotations-2.0.6.jar:lib/jackson-core-2.0.6.jar:lib/jackson-databind-2.0.6.jar:lib/jakarta-regexp-1.5.jar:lib/javacsv.jar:lib/javax.servlet-api-3.1.0.jar:lib/jdom-2.0.5.jar:lib/jdom.jar:lib/jetty-http-9.3.9.v20160517.jar:lib/jetty-io-9.3.9.v20160517.jar:lib/jetty-security-9.3.9.v20160517.jar:lib/jetty-server-9.3.9.v20160517.jar:lib/jetty-servlet-9.3.9.v20160517.jar:lib/jetty-util-9.3.9.v20160517.jar:lib/jhall.jar:lib/jhidrawplugin.jar:lib/jinput.jar:lib/jlfgr-1_0.jar:lib/jmdns.jar:lib/joal.jar:lib/jul-to-slf4j-1.7.13.jar:lib/jython.jar:lib/log4j-1.2.17.jar:lib/mailapi.jar:lib/openlcb.jar:lib/pi4j-core.jar:lib/pi4j-device.jar:lib/pi4j-gpio-extension.jar:lib/pi4j-service.jar:lib/slf4j-api-1.7.13.jar:lib/slf4j-log4j12-1.7.13.jar:lib/smtp.jar:lib/vecmath-1.5.2.jar:lib/websocket-api-9.3.9.v20160517.jar:lib/websocket-client-9.3.9.v20160517.jar:lib/websocket-common-9.3.9.v20160517.jar:lib/websocket-server-9.3.9.v20160517.jar:lib/websocket-servlet-9.3.9.v20160517.jar:lib/xAPlib.jar:lib/xbee-api-0.9.jar:lib/xercesImpl.jar'
Java CMD: '/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java'
APPNAME: 'DecoderPro'
OPTIONS: ' -noverify -Djava.security.policy=lib/security.policy -Djava.rmi.server.codebase=file:java/classes/ -Djava.library.path=.:lib/macosx:lib -Dapple.laf.useScreenMenuBar=true -Dcom.apple.macos.useScreenMenuBar=true -Dfile.encoding=UTF-8 -Xms96m -Xmx1024m -Dgnu.io.rxtx.NoVersionOutput=true'
DOCK_OPTIONS: '-Xdock:name=DecoderPro -Xdock:icon=/Volumes/JMRI 4.5.3ish-201608170220-heap-R10da6d0/JMRI/DecoderPro.app/Contents/Resources/DecoderPro.icns'
2016-08-17 12:29:34,162 util.Log4JUtil INFO - ****** JMRI log ******* [main]
2016-08-17 12:29:36,551 util.Log4JUtil INFO - This log is appended to file: /Users/NEMRC/Library/Preferences/JMRI/log/messages.log [main]
2016-08-17 12:29:36,553 util.Log4JUtil INFO - This log is stored in file: /Users/NEMRC/Library/Preferences/JMRI/log/session.log [main]
2016-08-17 12:29:36,569 apps.AppsBase INFO - DecoderPro version 4.5.3ish-201608170220-heap-R10da6d0 starts under Java 1.8.0_101 on Mac OS X x86_64 v10.9.5 at Wed Aug 17 12:29:36 AEST 2016 [main]
2016-08-17 12:29:39,413 gui3.Apps3 INFO - Starting with profile NCE_Simulator.3f2fe34b [main]
2016-08-17 12:29:39,509 node.NodeIdentity INFO - Using jmri-00254BABE722-3f2fe34b as the JMRI Node identity [main]
2016-08-17 12:29:39,759 simulator.SimulatorAdapter INFO - NCE Simulator Started [Nce Simulator]
2016-08-17 12:29:39,827 nce.NceConnectionStatus INFO - NCE EPROM revision = 6.2.1 [AWT-EventQueue-0]
2016-08-17 12:29:41,055 util.FileUtilSupport INFO - File path program: is /Volumes/JMRI 4.5.3ish-201608170220-heap-R10da6d0/JMRI/ [main]
2016-08-17 12:29:41,064 util.FileUtilSupport INFO - File path preference: is /Users/NEMRC/Library/Preferences/JMRI/ [main]
2016-08-17 12:29:41,066 util.FileUtilSupport INFO - File path profile: is /Users/NEMRC/Library/Preferences/JMRI/NCE_Simulator/ [main]
2016-08-17 12:29:41,076 util.FileUtilSupport INFO - File path settings: is /Users/NEMRC/Library/Preferences/JMRI/ [main]
2016-08-17 12:29:41,080 util.FileUtilSupport INFO - File path home: is /Users/NEMRC/ [main]
2016-08-17 12:29:41,092 util.FileUtilSupport INFO - File path scripts: is /Volumes/JMRI 4.5.3ish-201608170220-heap-R10da6d0/JMRI/jython/ [main]
2016-08-17 12:29:41,814 swing.RosterFrame ERROR - Unable to get the double click speed, Using JMRI default of half a secondjava.lang.NullPointerException [main]
2016-08-17 12:29:45,944 managers.DefaultShutDownManager INFO - Normal termination complete [AWT-EventQueue-0]
Exit Status: 0
New-England-Model-Railway-Club-Inc:~ NEMRC$

@rhwood

Fixes should be in the PR now. I moved the calls to determine memory requirements to be later than the determine of which Java to use. Can you test this one last time?

Contributor

dheap commented Aug 17, 2016

All good now. Thanks for chasing this up. Now back to saw bench and drill press...

New-England-Model-Railway-Club-Inc:~ NEMRC$ /Volumes/JMRI\ 4.5.3ish-201608170220-heap-R10da6d0/JMRI/DecoderPro.app/Contents/MacOS/StartJMRI
PWD: '/Volumes/JMRI 4.5.3ish-201608170220-heap-R10da6d0/JMRI'
CLASSPATH: '.:classes:java/classes:jmri.jar:lib/RXTXcomm.jar:lib/Serialio.jar:lib/WinRegistry-4.4.jar:lib/beansbinding-1.2.1.jar:lib/bluecove-2.1.1-SNAPSHOT.jar:lib/bluecove-bluez-2.1.1-SNAPSHOT.jar:lib/bluecove-gpl-2.1.1-SNAPSHOT.jar:lib/ch.ntb.usb.jar:lib/commons-io-1.3.1.jar:lib/commons-lang3-3.2.1.jar:lib/gluegen-rt.jar:lib/jackson-annotations-2.0.6.jar:lib/jackson-core-2.0.6.jar:lib/jackson-databind-2.0.6.jar:lib/jakarta-regexp-1.5.jar:lib/javacsv.jar:lib/javax.servlet-api-3.1.0.jar:lib/jdom-2.0.5.jar:lib/jdom.jar:lib/jetty-http-9.3.9.v20160517.jar:lib/jetty-io-9.3.9.v20160517.jar:lib/jetty-security-9.3.9.v20160517.jar:lib/jetty-server-9.3.9.v20160517.jar:lib/jetty-servlet-9.3.9.v20160517.jar:lib/jetty-util-9.3.9.v20160517.jar:lib/jhall.jar:lib/jhidrawplugin.jar:lib/jinput.jar:lib/jlfgr-1_0.jar:lib/jmdns.jar:lib/joal.jar:lib/jul-to-slf4j-1.7.13.jar:lib/jython.jar:lib/log4j-1.2.17.jar:lib/mailapi.jar:lib/openlcb.jar:lib/pi4j-core.jar:lib/pi4j-device.jar:lib/pi4j-gpio-extension.jar:lib/pi4j-service.jar:lib/slf4j-api-1.7.13.jar:lib/slf4j-log4j12-1.7.13.jar:lib/smtp.jar:lib/vecmath-1.5.2.jar:lib/websocket-api-9.3.9.v20160517.jar:lib/websocket-client-9.3.9.v20160517.jar:lib/websocket-common-9.3.9.v20160517.jar:lib/websocket-server-9.3.9.v20160517.jar:lib/websocket-servlet-9.3.9.v20160517.jar:lib/xAPlib.jar:lib/xbee-api-0.9.jar:lib/xercesImpl.jar'
Java CMD: '/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java'
APPNAME: 'DecoderPro'
OPTIONS: ' -noverify -Djava.security.policy=lib/security.policy -Djava.rmi.server.codebase=file:java/classes/ -Djava.library.path=.:lib/macosx:lib -Dapple.laf.useScreenMenuBar=true -Dcom.apple.macos.useScreenMenuBar=true -Dfile.encoding=UTF-8 -Xms96m -Xmx1024m -Dgnu.io.rxtx.NoVersionOutput=true'
DOCK_OPTIONS: '-Xdock:name=DecoderPro -Xdock:icon=/Volumes/JMRI 4.5.3ish-201608170220-heap-R10da6d0/JMRI/DecoderPro.app/Contents/Resources/DecoderPro.icns'
2016-08-17 12:29:34,162 util.Log4JUtil INFO - ****** JMRI log ******* [main]
2016-08-17 12:29:36,551 util.Log4JUtil INFO - This log is appended to file: /Users/NEMRC/Library/Preferences/JMRI/log/messages.log [main]
2016-08-17 12:29:36,553 util.Log4JUtil INFO - This log is stored in file: /Users/NEMRC/Library/Preferences/JMRI/log/session.log [main]
2016-08-17 12:29:36,569 apps.AppsBase INFO - DecoderPro version 4.5.3ish-201608170220-heap-R10da6d0 starts under Java 1.8.0_101 on Mac OS X x86_64 v10.9.5 at Wed Aug 17 12:29:36 AEST 2016 [main]
2016-08-17 12:29:39,413 gui3.Apps3 INFO - Starting with profile NCE_Simulator.3f2fe34b [main]
2016-08-17 12:29:39,509 node.NodeIdentity INFO - Using jmri-00254BABE722-3f2fe34b as the JMRI Node identity [main]
2016-08-17 12:29:39,759 simulator.SimulatorAdapter INFO - NCE Simulator Started [Nce Simulator]
2016-08-17 12:29:39,827 nce.NceConnectionStatus INFO - NCE EPROM revision = 6.2.1 [AWT-EventQueue-0]
2016-08-17 12:29:41,055 util.FileUtilSupport INFO - File path program: is /Volumes/JMRI 4.5.3ish-201608170220-heap-R10da6d0/JMRI/ [main]
2016-08-17 12:29:41,064 util.FileUtilSupport INFO - File path preference: is /Users/NEMRC/Library/Preferences/JMRI/ [main]
2016-08-17 12:29:41,066 util.FileUtilSupport INFO - File path profile: is /Users/NEMRC/Library/Preferences/JMRI/NCE_Simulator/ [main]
2016-08-17 12:29:41,076 util.FileUtilSupport INFO - File path settings: is /Users/NEMRC/Library/Preferences/JMRI/ [main]
2016-08-17 12:29:41,080 util.FileUtilSupport INFO - File path home: is /Users/NEMRC/ [main]
2016-08-17 12:29:41,092 util.FileUtilSupport INFO - File path scripts: is /Volumes/JMRI 4.5.3ish-201608170220-heap-R10da6d0/JMRI/jython/ [main]
2016-08-17 12:29:41,814 swing.RosterFrame ERROR - Unable to get the double click speed, Using JMRI default of half a secondjava.lang.NullPointerException [main]
2016-08-17 12:29:45,944 managers.DefaultShutDownManager INFO - Normal termination complete [AWT-EventQueue-0]
Exit Status: 0
New-England-Model-Railway-Club-Inc:~ NEMRC$

@rhwood

Fixes should be in the PR now. I moved the calls to determine memory requirements to be later than the determine of which Java to use. Can you test this one last time?

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Aug 17, 2016

Contributor

@dheap Thanks for testing this.

I'd like this in a 4.5.3 sooner rather than later. Am merging so at least any build out of master gets the corrected scripts.

Contributor

rhwood commented Aug 17, 2016

@dheap Thanks for testing this.

I'd like this in a 4.5.3 sooner rather than later. Am merging so at least any build out of master gets the corrected scripts.

@rhwood rhwood merged commit 50dc401 into master Aug 17, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rhwood rhwood deleted the rhwood-patch-1 branch Aug 17, 2016

rhwood added a commit to JMRI/website that referenced this pull request Aug 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment