Catch NPEs creating Sound objects #1808

Merged
merged 5 commits into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@rhwood
Contributor

rhwood commented Aug 16, 2016

Proposed fix for #1806.

@rhwood rhwood added the Bug label Aug 16, 2016

@KenC57

This comment has been minimized.

Show comment
Hide comment
@KenC57

KenC57 Aug 17, 2016

Contributor

Looks like it covers what I was following. If I could figure out an easy way to pull this into my Eclipse, I'd try it on my 'bad' panel. But it does look good enough for now.

Contributor

KenC57 commented Aug 17, 2016

Looks like it covers what I was following. If I could figure out an easy way to pull this into my Eclipse, I'd try it on my 'bad' panel. But it does look good enough for now.

@rhwood rhwood merged commit e9c7591 into JMRI:master Aug 17, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Aug 17, 2016

Contributor

@KenC57 thanks for the review. I've merged it so you can review from the master branch.

Contributor

rhwood commented Aug 17, 2016

@KenC57 thanks for the review. I've merged it so you can review from the master branch.

@rhwood rhwood modified the milestone: 4.5.3 Aug 19, 2016

rhwood added a commit to JMRI/website that referenced this pull request Aug 19, 2016

@rhwood rhwood deleted the rhwood:sounds branch Nov 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment