New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedo was broken after changes for multi-system. Removed duplicate t… #2027

Merged
merged 3 commits into from Oct 3, 2016

Conversation

Projects
None yet
3 participants
@crosland
Contributor

crosland commented Oct 2, 2016

…raffic controller instance and tidied up.

crosland
Speedo was broken after changes for multi-system. Removed duplicate t…
…raffic controller instance and tidied up.
@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Oct 2, 2016

Member

AppVeyor failed to compile:

    [javac] Compiling 1917 source files to C:\projects\jmri\java\test-classes
    [javac] C:\projects\jmri\java\test\jmri\jmrix\bachrus\SpeedoTrafficControllerTest.java:19: error: constructor SpeedoTrafficController in class SpeedoTrafficController cannot be applied to given types;
    [javac]         SpeedoTrafficController m = new SpeedoTrafficController();
    [javac]                                     ^
    [javac]   required: SpeedoSystemConnectionMemo
    [javac]   found: no arguments
    [javac]   reason: actual and formal argument lists differ in length

Were all the right files committed?

Member

bobjacobsen commented Oct 2, 2016

AppVeyor failed to compile:

    [javac] Compiling 1917 source files to C:\projects\jmri\java\test-classes
    [javac] C:\projects\jmri\java\test\jmri\jmrix\bachrus\SpeedoTrafficControllerTest.java:19: error: constructor SpeedoTrafficController in class SpeedoTrafficController cannot be applied to given types;
    [javac]         SpeedoTrafficController m = new SpeedoTrafficController();
    [javac]                                     ^
    [javac]   required: SpeedoSystemConnectionMemo
    [javac]   found: no arguments
    [javac]   reason: actual and formal argument lists differ in length

Were all the right files committed?

@crosland

This comment has been minimized.

Show comment
Hide comment
@crosland

crosland Oct 2, 2016

Contributor

No, I forgot oabout the imipact on the tests.

Sorry, I'll try and fix it.

Andrew

------ Original Message ------
From: "Bob Jacobsen" notifications@github.com
To: "JMRI/JMRI" JMRI@noreply.github.com
Cc: "Andrew Crosland" andrew@crosland.me.uk; "Author"
author@noreply.github.com
Sent: 02/10/2016 19:52:25
Subject: Re: [JMRI/JMRI] Speedo was broken after changes for
multi-system. Removed duplicate t… (#2027)

AppVeyor failed to compile:

[javac] Compiling 1917 source files to
C:\projects\jmri\java\test-classes [javac]
C:\projects\jmri\java\test\jmri\jmrix\bachrus\SpeedoTrafficControllerTest.java:19:
error: constructor SpeedoTrafficController in class
SpeedoTrafficController cannot be applied to given types; [javac]
SpeedoTrafficController m = new SpeedoTrafficController(); [javac] ^
[javac] required: SpeedoSystemConnectionMemo [javac] found: no
arguments [javac] reason: actual and formal argument lists differ in
length
Were all the right files committed?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Contributor

crosland commented Oct 2, 2016

No, I forgot oabout the imipact on the tests.

Sorry, I'll try and fix it.

Andrew

------ Original Message ------
From: "Bob Jacobsen" notifications@github.com
To: "JMRI/JMRI" JMRI@noreply.github.com
Cc: "Andrew Crosland" andrew@crosland.me.uk; "Author"
author@noreply.github.com
Sent: 02/10/2016 19:52:25
Subject: Re: [JMRI/JMRI] Speedo was broken after changes for
multi-system. Removed duplicate t… (#2027)

AppVeyor failed to compile:

[javac] Compiling 1917 source files to
C:\projects\jmri\java\test-classes [javac]
C:\projects\jmri\java\test\jmri\jmrix\bachrus\SpeedoTrafficControllerTest.java:19:
error: constructor SpeedoTrafficController in class
SpeedoTrafficController cannot be applied to given types; [javac]
SpeedoTrafficController m = new SpeedoTrafficController(); [javac] ^
[javac] required: SpeedoSystemConnectionMemo [javac] found: no
arguments [javac] reason: actual and formal argument lists differ in
length
Were all the right files committed?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

crosland added some commits Oct 2, 2016

crosland
Fix for function keys on programmer mode. Create command station for …
…sprog programmer mode, which was poeviously part of throttle code.

@crosland crosland closed this Oct 2, 2016

@crosland crosland reopened this Oct 2, 2016

@rhwood rhwood added the Bug label Oct 3, 2016

@rhwood rhwood added this to the 4.5.5 milestone Oct 3, 2016

@rhwood rhwood merged commit b93dd69 into JMRI:master Oct 3, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Oct 3, 2016

Contributor

@crosland Do you have specific text you want in the release notes?

Contributor

rhwood commented Oct 3, 2016

@crosland Do you have specific text you want in the release notes?

@crosland

This comment has been minimized.

Show comment
Hide comment
@crosland

crosland Oct 3, 2016

Contributor

If it's sufficient, I am happy with the commit comments.

Andrew

------ Original Message ------
From: "Randall Wood" notifications@github.com
To: "JMRI/JMRI" JMRI@noreply.github.com
Cc: "Andrew Crosland" andrew@crosland.me.uk; "Mention"
mention@noreply.github.com
Sent: 03/10/2016 10:02:30
Subject: Re: [JMRI/JMRI] Speedo was broken after changes for
multi-system. Removed duplicate t… (#2027)

@crosland Do you have specific text you want in the release notes?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Contributor

crosland commented Oct 3, 2016

If it's sufficient, I am happy with the commit comments.

Andrew

------ Original Message ------
From: "Randall Wood" notifications@github.com
To: "JMRI/JMRI" JMRI@noreply.github.com
Cc: "Andrew Crosland" andrew@crosland.me.uk; "Mention"
mention@noreply.github.com
Sent: 03/10/2016 10:02:30
Subject: Re: [JMRI/JMRI] Speedo was broken after changes for
multi-system. Removed duplicate t… (#2027)

@crosland Do you have specific text you want in the release notes?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

rhwood added a commit to JMRI/website that referenced this pull request Oct 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment