New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundTraxx OEM decoders for PIKO steam locomotives #2716

Merged
merged 2 commits into from Dec 18, 2016

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Dec 18, 2016

Added CV7 = 84 , determining decoder type

MarcFour

@ghost ghost closed this Dec 18, 2016

@ghost ghost reopened this Dec 18, 2016

<!-- FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License -->
<!-- for more details. -->
<decoder-config xmlns:xi="http://www.w3.org/2001/XInclude" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://jmri.org/xml/schema/decoder.xsd">
<version author="Jeff Schmaltz 493rdafa@gmail.com" version="1" lastUpdated="20131011"/>

This comment has been minimized.

@rhwood

rhwood Dec 18, 2016

Contributor

@MarcFour Thank you for the decoder file. I have one request: Can you please update the version by updating this line and the comment starting in line 17 and crediting Jeff Schmaltz in the comment?

If you make this change in your fork and commit and push it, this pull request will get automatically updated with that change.

@rhwood

rhwood Dec 18, 2016

Contributor

@MarcFour Thank you for the decoder file. I have one request: Can you please update the version by updating this line and the comment starting in line 17 and crediting Jeff Schmaltz in the comment?

If you make this change in your fork and commit and push it, this pull request will get automatically updated with that change.

@rhwood rhwood added the Enhancement label Dec 18, 2016

MarcFour
Add lowVersion 84
Addd lowVersion 84 to CV7 to assist DecoderPro determine decoder type.
Added comment, credit
@rhwood

rhwood approved these changes Dec 18, 2016

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Dec 18, 2016

Contributor

@MarcFour thank you for the contribution

Contributor

rhwood commented Dec 18, 2016

@MarcFour thank you for the contribution

@rhwood rhwood merged commit f8c1026 into JMRI:master Dec 18, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rhwood rhwood added this to the 4.7.1 milestone Dec 18, 2016

@rhwood rhwood changed the title from Add files via upload to SoundTraxx OEM decoders for PIKO steam locomotives Dec 18, 2016

rhwood added a commit to JMRI/website that referenced this pull request Dec 18, 2016

mattharris added a commit to mattharris/JMRI that referenced this pull request Dec 21, 2016

@mattharris

This comment has been minimized.

Show comment
Hide comment
@mattharris

mattharris Dec 21, 2016

Member

Looks like this erroneously put a copy of the decoder file in the repo root. #2741 fixes this.

Member

mattharris commented Dec 21, 2016

Looks like this erroneously put a copy of the decoder file in the repo root. #2741 fixes this.

mattharris added a commit that referenced this pull request Dec 21, 2016

Merge pull request #2741 from mattharris/mjh-fix-2716
Remove file inadvertently added as part of #2716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment