Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove deprecated portable paths #2719
Addresses #2710 by removing the
I believe that existing XML files or scripts that still refer to either of these portable paths will throw either a FileNotFoundException or NullPointerException (depending on how they request the actual file) and, unless they silently swallow those errors will either log the file as not findable or display an error. Note that the portable path will simply be passed through as part of the file name in these cases.
A review of the history of FileUtil suggests that only panel files written by JMRI version 2.8 or older will have either of these portable paths in them.
Marked WIP due to uncertainty about how to handle XML schema that allows the removed portable path
See #2710 for discussion about decisions taken in this PR.
referenced this pull request
Dec 18, 2016
I know I am missing some missing classes in the help content, but am not confident I can identify all the missing classes and their replacements. I also don't want to hold this on developing a tool or tools to help fix these issues (I have identified unrelated issues while working on this, the fixes for which would conflict with changes in this PR, so I'd like to merge it sooner rather than later so the other (pending) PRs can also be submitted).
Generally ok. It seems a few other changes got sucked in, like rps stuff for example, and some editor stuff (rotations). One thing I'm not sure of is if the samples should be translated or used as 'bad' samples to support testing. But not sure how those are supposed to be used here.
The rps tests fail without these changes--the rps test data was invalid (it contained xml newer than the schema it validated against) and to find that error I had to add the user Config manager to the tests. There's some other cleanup in those tests as well as a result. I've added a sample bad file that is only bad because of invalid paths to the CI tests--most of the other tests files in the CI test suite can used for testing as well.