New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vsdecoder SoundBiteTest and cleanup #3019

Merged
merged 11 commits into from Feb 9, 2017

Conversation

Projects
None yet
3 participants
@klk32003
Contributor

klk32003 commented Feb 7, 2017

See #2539 for background.

  • Drop vsd_file_base (path to a vsdecoder folder intended to hold WAV files) in VSDSound.java. This path was used realy only in SoundBiteTest.java (today all WAV files are embedded in VSD files)

  • Reduce constructors in SoundBite.java, delete vsd_file_base

  • Define a path in SoundBiteTest.java and adapt constructor changes

  • Cleanups

This patch should clean the WARN messages vsdecodernull (No such file or directory) in CI-test Travis OSX build.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 7, 2017

Coverage Status

Coverage decreased (-0.003%) to 30.131% when pulling ce2b5c7 on klk32003:vsdecoder-junit-tests-patch into 9510827 on JMRI:master.

coveralls commented Feb 7, 2017

Coverage Status

Coverage decreased (-0.003%) to 30.131% when pulling ce2b5c7 on klk32003:vsdecoder-junit-tests-patch into 9510827 on JMRI:master.

@rhwood rhwood merged commit 796d991 into JMRI:master Feb 9, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 30.131%
Details
@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Feb 9, 2017

Contributor

@klk32003 Thank you.

Contributor

rhwood commented Feb 9, 2017

@klk32003 Thank you.

@rhwood rhwood added the Cleanup label Feb 9, 2017

@klk32003 klk32003 deleted the klk32003:vsdecoder-junit-tests-patch branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment