New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WinRegistry with JNA #3353

Merged
merged 6 commits into from Apr 10, 2017

Conversation

Projects
None yet
4 participants
@rhwood
Contributor

rhwood commented Apr 7, 2017

Replace the WinRegistry library with Java Native Access (JNA) for access to the Windows Registry. JNA is a currently maintained library for native access to shared libraries across multiple platforms.

Although JNA is a general-purpose native access library for Java, it includes utilities for accessing Windows Registry entries. Recent versions of WinRegistry rely on exposing deliberately un-exposed implementation details in the java.util.prefs package, are developed and tested not in the open, and are not distributed using maven-compatible means.

rhwood added some commits Mar 17, 2017

Replace WinRegistry with JNA
JNA is a general-purpose native access library for Java, which includes
utilities for accessing Windows Registry entries. Recent versions of
WinRegistry rely on exposing deliberately un-exposed implementation
details in the java.util.prefs package, are developed and tested not in
the open, and are not distributed using maven-compatible means.
Merge remote-tracking branch 'JMRI/master' into jna
# Conflicts:
#	nbproject/project.xml
Merge remote-tracking branch 'JMRI/master' into jna
# Conflicts:
#	nbproject/project.xml
@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen Apr 8, 2017

Member

This removes older library files. @mattharris does the Windows installer need modifications for that? There was discussion of this in #359 but I don't know the status of that.

Member

bobjacobsen commented Apr 8, 2017

This removes older library files. @mattharris does the Windows installer need modifications for that? There was discussion of this in #359 but I don't know the status of that.

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Apr 8, 2017

Contributor

Since these two libraries do not conflict, there is no harm in leaving the old library in place for any user scripts that may rely on it.

Contributor

rhwood commented Apr 8, 2017

Since these two libraries do not conflict, there is no harm in leaving the old library in place for any user scripts that may rely on it.

@mattharris

This comment has been minimized.

Show comment
Hide comment
@mattharris

mattharris Apr 9, 2017

Member

@bobjacobsen There still isn't anything done with regard restructuring the installation routine to deal with removal of old installation files. As @rhwood mentions, in this case it's pretty benign to leave this one around as opposed to explicitly removing it as it shouldn't have any dependency conflicts.

But I do need to come back to the whole installer question at some point...

Member

mattharris commented Apr 9, 2017

@bobjacobsen There still isn't anything done with regard restructuring the installation routine to deal with removal of old installation files. As @rhwood mentions, in this case it's pretty benign to leave this one around as opposed to explicitly removing it as it shouldn't have any dependency conflicts.

But I do need to come back to the whole installer question at some point...

@petecressman

This comment has been minimized.

Show comment
Hide comment
@petecressman

petecressman Apr 9, 2017

Contributor

Built and run PanelPro with simulated connections from Eclipse. Looks OK. What should be tested?

Contributor

petecressman commented Apr 9, 2017

Built and run PanelPro with simulated connections from Eclipse. Looks OK. What should be tested?

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Apr 9, 2017

Contributor
Contributor

rhwood commented Apr 9, 2017

@petecressman

This comment has been minimized.

Show comment
Hide comment
@petecressman

petecressman Apr 9, 2017

Contributor

Layout currently disabled. However, attempting to set, save and relaunch real connections seemed to give the appropriate error messages.

Contributor

petecressman commented Apr 9, 2017

Layout currently disabled. However, attempting to set, save and relaunch real connections seemed to give the appropriate error messages.

@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood Apr 10, 2017

Contributor

@petecressman Thank you for testing.

Contributor

rhwood commented Apr 10, 2017

@petecressman Thank you for testing.

@rhwood rhwood merged commit 244b3a6 into JMRI:master Apr 10, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.005%) to 32.855%
Details

@rhwood rhwood deleted the rhwood:jna branch Apr 10, 2017

@rhwood rhwood self-assigned this Apr 10, 2017

@rhwood rhwood added this to the 4.7.3 milestone Apr 10, 2017

@rhwood rhwood added the Cleanup label Apr 10, 2017

rhwood added a commit to JMRI/website that referenced this pull request Apr 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment