New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to LocoNet over TCP server #3498

Merged
merged 35 commits into from May 24, 2017

Conversation

Projects
None yet
2 participants
@rhwood
Contributor

rhwood commented May 13, 2017

Make the LocoNet over TCP server behave more like the other servers.

rhwood added some commits May 13, 2017

Allow the unregistration of null tasks
The acceptance of null tasks at unregistration allows simpler code to
unregister a task elsewhere in the code.
Move server preferences into preferences panels
The severity of this change is that users using the non-default port
will need to reset the port and that users who expected to be able to
open the server monitor window without starting the server will need to
change expectations (this server now behaves like other servers with
UI).

@rhwood rhwood added the WIP label May 13, 2017

@rhwood rhwood self-assigned this May 13, 2017

@bobjacobsen

This comment has been minimized.

Show comment
Hide comment
@bobjacobsen

bobjacobsen May 14, 2017

Member

Travis graphics failed on a JavaDoc error:

  [javadoc] /home/travis/build/JMRI/JMRI/java/src/jmri/jmrix/loconet/loconetovertcp/Server.java:108: error: reference not found
  [javadoc]      * {@link jmri.jmrix.loconet.loconetovertcp.LnTcpPreferences#setPort()}
  [javadoc]               ^
Member

bobjacobsen commented May 14, 2017

Travis graphics failed on a JavaDoc error:

  [javadoc] /home/travis/build/JMRI/JMRI/java/src/jmri/jmrix/loconet/loconetovertcp/Server.java:108: error: reference not found
  [javadoc]      * {@link jmri.jmrix.loconet.loconetovertcp.LnTcpPreferences#setPort()}
  [javadoc]               ^

rhwood added some commits May 17, 2017

Rename Server class to LnTcpServer
This is done without deprecation since the constructor for the
LnTcpServer is private.
Remove the power manager from the tests
This now makes me think that I only needed to reset the InstanceManager
in 92d352f instead of also setting the
PowerManager.
Significant refactoring of server and monitor
Server allows multiple monitors; frames can be created for multiple
servers (standard UI and preferences only support a single
server—multiple servers would need to be scripted).
Restore ability to read old preferences
Allow old preferences to be migrated to new preferences structure.
@rhwood

This comment has been minimized.

Show comment
Hide comment
@rhwood

rhwood May 24, 2017

Contributor

Travis CI GUI for 251d138 failed on test addressed in #3522; restarted

Contributor

rhwood commented May 24, 2017

Travis CI GUI for 251d138 failed on test addressed in #3522; restarted

@rhwood rhwood removed the WIP label May 24, 2017

@rhwood rhwood merged commit 81ce243 into JMRI:master May 24, 2017

4 checks passed

VersionEye All software dependencies are fine. You are awesome!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 33.369%
Details

rhwood added a commit to JMRI/website that referenced this pull request May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment