New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout editor add check for unnecessary anchors #4513

Merged
merged 26 commits into from Dec 6, 2017

Conversation

Projects
5 participants
@geowar1
Contributor

geowar1 commented Dec 5, 2017

If adjacent track segments are collinear or one (or both) is(are) zero length.
Selecting an unnecessary anchor from the check menu will show it's popup where the adjacent track segments can be merged.

geowar1 and others added some commits Nov 19, 2017

fix NPE when deleting last section of transit when only 2 left
we dont need to check section direction when not in last block
SInce it hasnt gone yet.. Change to correct description.
We allocate by sections not blocks.
JComboBoxUtil.setupComboBoxMaxRows();-bump-by-one-when-isFirstItemBlank
if the first item is blank then increase the maximum row count by one
Merge pull request #4507 from pabender/master
add a jemmy queuetool wait to see if we can eliminte an occasional hickup in test.
Fix defaulticon element
Light state element name matches updated properties key StateOn. Fixes CPE Drag-n-Drop for Lights.
Merge pull request #4505 from Pugwash1/Fix-NPESections-AutoTurnouts
fix NPE when deleting last section of transit when only 2 left
Merge pull request #4509 from geowar1/JComboBoxUtil.setupComboBoxMaxR…
…ows();-bump-by-one-when-isFirstItemBlank

JComboBoxUtil.setupComboBoxMaxRows();-bump-by-one-when-isFirstItemBlank
Merge pull request #4510 from geowar1/BUGFIX-foundObject-not-getting-…
…cleared-on-mouseReleased

BUGFIX-foundObject-not-getting-cleared-on-mouseReleased
Merge pull request #4511 from silverailscolo/patch-5
Fix defaulticon xml element
LayoutEditor:Add Check for... Anchors attached to Zero-Length Track S…
…egments

Lots of FindBug fixes.
Minor dead-code stripping.
Minor bugfix for drawing LayoutSlip (crossing) diamond
@geowar1

This comment has been minimized.

Contributor

geowar1 commented Dec 5, 2017

Note: Not WIP: can be assigned and merged if(/when) all checks pass.

@bobjacobsen bobjacobsen merged commit 82850f4 into JMRI:LayoutEditor-development Dec 6, 2017

4 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 39.706%
Details

@geowar1 geowar1 deleted the geowar1:LayoutEditor-Add-Check-for-Anchors-attached-to-zero-length-track-segments branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment