New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Over: Decorations and Findbug fixes #4613

Merged
merged 3 commits into from Dec 24, 2017

Conversation

Projects
3 participants
@geowar1
Contributor

geowar1 commented Dec 22, 2017

No description provided.

@rhwood

This comment has been minimized.

Contributor

rhwood commented on bf9f75c Dec 23, 2017

This should be done by using xovers.toArray(new LayoutTurnout[xovers.size()]) and leasve the resultant combobox typed.

@geowar1

This comment has been minimized.

Contributor

geowar1 commented Dec 23, 2017

Thanks for that; I’ve been fighting with the syntax with the compiler and findbugs on almost every commit.

@rhwood

This comment has been minimized.

Contributor

rhwood commented Dec 23, 2017

FindBugs Bug Descriptions has explanations and usually solutions for anything FindBugs flags. This could also (because JComboBoxes take Vectors) be written as JComboBox<LayoutTurnout> jcb = new JComboBox<>(new Vector<>(xovers));

@bobjacobsen bobjacobsen merged commit 12064c5 into JMRI:LayoutEditor-development Dec 24, 2017

4 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on LayoutEditor-development at 39.639%
Details

@geowar1 geowar1 deleted the geowar1:Do-Over-Decorations-and-Findbug-fixes branch Dec 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment