New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSDecoder: replace getLength() in AudioUtil #4826

Merged
merged 2 commits into from Jan 26, 2018

Conversation

Projects
None yet
2 participants
@klk32003
Contributor

klk32003 commented Jan 26, 2018

Method getLength() gives an audio format error on empty buffers, because they have no format attribute to calculate the buffer length. More applicable is method getState().

@bobjacobsen bobjacobsen added this to the 4.11.3 milestone Jan 26, 2018

@bobjacobsen bobjacobsen merged commit f0f852d into JMRI:master Jan 26, 2018

4 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 40.652%
Details

@klk32003 klk32003 deleted the klk32003:vsdecoder-replace-getlength-in-audioutil branch Jan 26, 2018

@klk32003

This comment has been minimized.

Contributor

klk32003 commented Jan 26, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment